You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/31 19:14:32 UTC
[GitHub] [airflow] mik-laj opened a new pull request #13413: Replace tests-only dependency - tzlocal
mik-laj opened a new pull request #13413:
URL: https://github.com/apache/airflow/pull/13413
https://github.com/apache/airflow/search?q=tzlocal
This dependency is only used in testing and we have another more common alternative.
Part of: https://github.com/apache/airflow/issues/12120
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13413: Replace tests-only dependency - tzlocal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13413:
URL: https://github.com/apache/airflow/pull/13413#issuecomment-753469241
[The Workflow run](https://github.com/apache/airflow/actions/runs/457651088) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13413: Replace tests-only dependency - tzlocal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13413:
URL: https://github.com/apache/airflow/pull/13413#issuecomment-753031304
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13413: Replace tests-only dependency - tzlocal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13413:
URL: https://github.com/apache/airflow/pull/13413#issuecomment-753476560
[The Workflow run](https://github.com/apache/airflow/actions/runs/457729102) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #13413: Replace tests-only dependency - tzlocal
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #13413:
URL: https://github.com/apache/airflow/pull/13413#issuecomment-753465137
@mik-laj can ou please rebase this one? It appears that curl command hanged and CI image was not downloaded: https://github.com/apache/airflow/pull/13413/checks?check_run_id=1635401914
This PR #13431 should fix it permanently (I added timeouts to all curl commands). Rebasing this one in the meantime might help
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #13413: Replace tests-only dependency - tzlocal
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #13413:
URL: https://github.com/apache/airflow/pull/13413
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13413: Replace tests-only dependency - tzlocal
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13413:
URL: https://github.com/apache/airflow/pull/13413#issuecomment-753465137
@mik-laj can ou please rebase this one. It appears that curl command hanged and CI image was not downloaded: https://github.com/apache/airflow/pull/13413/checks?check_run_id=1635401914
This PR #13431 should fix it permanently (I added timeouts to all curl commands). Rebasing this one in the meantime might help
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org