You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chi Zhang <ch...@gmail.com> on 2015/07/02 00:44:17 UTC
Review Request 36113: perf: refactored parse to allow determining an
output parsing function based on the runtime version.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36113/
-----------------------------------------------------------
Review request for mesos, Ian Downes, Paul Brett, and Cong Wang.
Bugs: mesos-2834
https://issues.apache.org/jira/browse/mesos-2834
Repository: mesos
Description
-------
perf: refactored parse to allow determining an output parsing function based on the runtime version.
Diffs
-----
src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02
Diff: https://reviews.apache.org/r/36113/diff/
Testing
-------
Thanks,
Chi Zhang
Re: Review Request 36113: perf: refactored parse to allow determining
an output parsing function based on the runtime version.
Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36113/
-----------------------------------------------------------
(Updated July 2, 2015, 11:32 p.m.)
Review request for mesos, Ian Downes, Paul Brett, and Cong Wang.
Bugs: mesos-2834
https://issues.apache.org/jira/browse/mesos-2834
Repository: mesos
Description
-------
perf: refactored parse to allow determining an output parsing function based on the runtime version.
Diffs (updated)
-----
src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02
Diff: https://reviews.apache.org/r/36113/diff/
Testing
-------
Thanks,
Chi Zhang
Re: Review Request 36113: perf: refactored parse to allow determining
an output parsing function based on the runtime version.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36113/#review90167
-----------------------------------------------------------
src/linux/perf.cpp (lines 471 - 472)
<https://reviews.apache.org/r/36113/#comment143159>
This is not converting a line, it's converting a vector of tokens. Can you pass in the actual line and tokenize here?
src/linux/perf.cpp (lines 493 - 497)
<https://reviews.apache.org/r/36113/#comment143161>
see below, this shouldn't be used by users directly, instead use an extract(line) wrapper function that determines the perf version and calls the appropriate parser
src/linux/perf.cpp (lines 509 - 512)
<https://reviews.apache.org/r/36113/#comment143160>
Perf version should be handled transparently to the caller, i.e., the user just calls extract(line) and gets the right output.
- Ian Downes
On July 1, 2015, 3:44 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36113/
> -----------------------------------------------------------
>
> (Updated July 1, 2015, 3:44 p.m.)
>
>
> Review request for mesos, Ian Downes, Paul Brett, and Cong Wang.
>
>
> Bugs: mesos-2834
> https://issues.apache.org/jira/browse/mesos-2834
>
>
> Repository: mesos
>
>
> Description
> -------
>
> perf: refactored parse to allow determining an output parsing function based on the runtime version.
>
>
> Diffs
> -----
>
> src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02
>
> Diff: https://reviews.apache.org/r/36113/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chi Zhang
>
>
Re: Review Request 36113: perf: refactored parse to allow determining
an output parsing function based on the runtime version.
Posted by Chi Zhang <ch...@gmail.com>.
> On July 1, 2015, 11:31 p.m., Paul Brett wrote:
> > src/linux/perf.cpp, line 468
> > <https://reviews.apache.org/r/36113/diff/1/?file=997703#file997703line468>
> >
> > Could you replace the function pointer with a lambda?
changed to not use a function pointer.
- Chi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36113/#review90161
-----------------------------------------------------------
On July 2, 2015, 11:32 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36113/
> -----------------------------------------------------------
>
> (Updated July 2, 2015, 11:32 p.m.)
>
>
> Review request for mesos, Ian Downes, Paul Brett, and Cong Wang.
>
>
> Bugs: mesos-2834
> https://issues.apache.org/jira/browse/mesos-2834
>
>
> Repository: mesos
>
>
> Description
> -------
>
> perf: refactored parse to allow determining an output parsing function based on the runtime version.
>
>
> Diffs
> -----
>
> src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02
>
> Diff: https://reviews.apache.org/r/36113/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chi Zhang
>
>
Re: Review Request 36113: perf: refactored parse to allow determining
an output parsing function based on the runtime version.
Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36113/#review90161
-----------------------------------------------------------
src/linux/perf.cpp (line 468)
<https://reviews.apache.org/r/36113/#comment143149>
Could you replace the function pointer with a lambda?
src/linux/perf.cpp (line 488)
<https://reviews.apache.org/r/36113/#comment143150>
Seems odd to return cgroup="" when there is no cgroup rather than just not add a cgroup entry to the map at all.
- Paul Brett
On July 1, 2015, 10:44 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36113/
> -----------------------------------------------------------
>
> (Updated July 1, 2015, 10:44 p.m.)
>
>
> Review request for mesos, Ian Downes, Paul Brett, and Cong Wang.
>
>
> Bugs: mesos-2834
> https://issues.apache.org/jira/browse/mesos-2834
>
>
> Repository: mesos
>
>
> Description
> -------
>
> perf: refactored parse to allow determining an output parsing function based on the runtime version.
>
>
> Diffs
> -----
>
> src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02
>
> Diff: https://reviews.apache.org/r/36113/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chi Zhang
>
>