[GitHub] [incubator-seatunnel] 531651225 commented on a diff in pull request #4752: [Improve][Connector-V2][StarRocks]StarRocks Sink connector support 2pc and eos

["531651225 (via GitHub)" <gi...@apache.org>]

531651225 commented on code in PR #4752:
URL: https://github.com/apache/incubator-seatunnel/pull/4752#discussion_r1195996388


##########
docs/en/connector-v2/sink/StarRocks.md:
##########
@@ -89,6 +99,14 @@ The amount of time to wait before attempting to retry a request to `StarRocks`
 
 Whether to enable upsert/delete, only supports PrimaryKey model.
 
+### enable-2pc [bool]
+
+Whether to enable two-phase commit (2pc), the default is true, to ensure Exactly-Once semantics. For two-phase commit, please refer to [here](https://docs.starrocks.io/zh-cn/latest/loading/Stream_Load_transaction_interface).
+
+### flush_frequency_ms [long]
+
+trigger flush frequency for batch writing ON EOS semantics

Review Comment:
   > Thank you for your suggestion, fix it
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org