You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/02/19 01:01:33 UTC
[GitHub] [solr] madrob commented on a change in pull request #658: Implement check for null scorer in DocSetQuery to simplify TestFilteredDocIdSet.testNullDocIdSet
madrob commented on a change in pull request #658:
URL: https://github.com/apache/solr/pull/658#discussion_r810420603
##########
File path: solr/core/src/test/org/apache/solr/search/TestFilteredDocIdSet.java
##########
@@ -133,24 +133,8 @@ public void testNullDocIdSet() throws Exception {
// Now search w/ a Query which returns a null Scorer
DocSetQuery f = new DocSetQuery(null) {
@Override
- public Weight createWeight(IndexSearcher searcher, ScoreMode scoreMode, float boost) {
- return new Weight(this) {
-
- @Override
- public Explanation explain(LeafReaderContext context, int doc) {
- return Explanation.match(0f, "No match on id " + doc);
- }
-
- @Override
- public Scorer scorer(LeafReaderContext leafReaderContext) {
- return null;
- }
-
- @Override
- public boolean isCacheable(LeafReaderContext ctx) {
- return false;
- }
- };
+ public Weight createWeight(IndexSearcher searcher, ScoreMode scoreMode, float boost) throws IOException {
Review comment:
Do we need this method at all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org