[jira] [Commented] (YARN-4397) if this addAll() function`s params is fault? @NodeListManager#getUnusableNodes()

["Daniel Templeton (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-4397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032083#comment-15032083 ] 

Daniel Templeton commented on YARN-4397:
----------------------------------------

I'm not sure I understand.  This function adds the contents of {{unusableRMNodesConcurrentSet}} to {{unUsableNodes}} and then returns the size of {{unusableRMNodesConcurrentSet}}.  {{unusableRMNodesConcurrentSet}} isn't modified, so the order doesn't matter.

> if this addAll() function`s params is fault? @NodeListManager#getUnusableNodes()
> --------------------------------------------------------------------------------
>
>                 Key: YARN-4397
>                 URL: https://issues.apache.org/jira/browse/YARN-4397
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: yarn
>    Affects Versions: 2.6.0
>            Reporter: Feng Yuan
>             Fix For: 2.8.0
>
>
> code in NodeListManager#144L:
>   /**
>    * Provides the currently unusable nodes. Copies it into provided collection.
>    * @param unUsableNodes
>    *          Collection to which the unusable nodes are added
>    * @return number of unusable nodes added
>    */
>   public int getUnusableNodes(Collection<RMNode> unUsableNodes) {
>     unUsableNodes.addAll(unusableRMNodesConcurrentSet);
>     return unusableRMNodesConcurrentSet.size();
>   }
> unUsableNodes and unusableRMNodesConcurrentSet's sequence is wrong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)