You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/03/18 10:31:26 UTC

[GitHub] [bookkeeper] eolivelli commented on pull request #2650: Allow to attach labels to metrics

eolivelli commented on pull request #2650:
URL: https://github.com/apache/bookkeeper/pull/2650#issuecomment-801809724


   @merlimat 
   we have a failing test, related to this patch
   
   ```
   Error:  Tests run: 9, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 0.545 s <<< FAILURE! - in org.apache.bookkeeper.stats.prometheus.TestPrometheusMetricsProvider
   Error:  org.apache.bookkeeper.stats.prometheus.TestPrometheusMetricsProvider.testCache  Time elapsed: 0.117 s  <<< FAILURE!
   java.lang.AssertionError: expected same:<or...@5f341870> was not:<or...@553f17c>
   	at org.junit.Assert.fail(Assert.java:88)
   	at org.junit.Assert.failNotSame(Assert.java:828)
   	at org.junit.Assert.assertSame(Assert.java:771)
   	at org.junit.Assert.assertSame(Assert.java:782)
   	at org.apache.bookkeeper.stats.prometheus.TestPrometheusMetricsProvider.testCache(TestPrometheusMetricsProvider.java:54)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org