You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/28 10:42:07 UTC

[GitHub] [arrow-datafusion] returnString commented on a change in pull request #214: Change SQL dialect to PostgreSQL

returnString commented on a change in pull request #214:
URL: https://github.com/apache/arrow-datafusion/pull/214#discussion_r622052668



##########
File path: datafusion/src/sql/parser.rs
##########
@@ -21,7 +21,7 @@
 
 use sqlparser::{
     ast::{ColumnDef, ColumnOptionDef, Statement as SQLStatement, TableConstraint},
-    dialect::{keywords::Keyword, Dialect, GenericDialect},
+    dialect::{keywords::Keyword, Dialect, PostgreSqlDialect},

Review comment:
       That's interesting approach - we'd have to be careful about our sqlparser => expr conversions, but that could be quite useful as a feature 🤔 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org