You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Aleksey Yeschenko (JIRA)" <ji...@apache.org> on 2018/08/29 21:49:00 UTC
[jira] [Commented] (CASSANDRA-14677) Clean up Message.Request
implementations
[ https://issues.apache.org/jira/browse/CASSANDRA-14677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596885#comment-16596885 ]
Aleksey Yeschenko commented on CASSANDRA-14677:
-----------------------------------------------
Code [here|https://github.com/iamaleksey/cassandra/commits/14677-4.0], CI [here|https://circleci.com/workflow-run/f02f947b-f709-4b11-a71b-69aabe21b1c8].
> Clean up Message.Request implementations
> ----------------------------------------
>
> Key: CASSANDRA-14677
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14677
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Aleksey Yeschenko
> Assignee: Aleksey Yeschenko
> Priority: Minor
> Fix For: 4.0.x
>
>
> First tracing support, many years ago, then most recently audit log, made a big mess out of {{Message.Request.execute()}} implementations.
> This patch tries to clean up some of it by removing tracing logic from {{QueryState}} and moving shared tracing functionality to {{Message.Request.perform()}}. It also moves out tracing and audit log boiler plate into their own small methods instead of polluting {{execute()}} implementations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org