You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Michael Brown (Code Review)" <ge...@cloudera.org> on 2016/06/03 23:11:12 UTC
[Impala-CR](cdh5-2.6.0 5.8.0) preview IMPALA-3630: forward end-to-end test arguments to custom cluster tests
Michael Brown has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3307
Change subject: preview IMPALA-3630: forward end-to-end test arguments to custom cluster tests
......................................................................
preview IMPALA-3630: forward end-to-end test arguments to custom cluster tests
The breakpad custom cluster tests expect to run in exhaustive only, but
the option to do that isn't passed appropriately. That means they aren't
being run at all in Jenkins.
Fix the problem by setting a common set of arguments in run-all-tests.sh
and passing them along as needed.
Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
---
M bin/run-all-tests.sh
1 file changed, 14 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/07/3307/4
--
To view, visit http://gerrit.cloudera.org:8080/3307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-CR](cdh5-2.6.0 5.8.0) preview IMPALA-3630: forward end-to-end test arguments to custom cluster tests
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: preview IMPALA-3630: forward end-to-end test arguments to custom cluster tests
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3307/4/bin/run-all-tests.sh
File bin/run-all-tests.sh:
PS4, Line 89: exploration_strategy
> My assumption was, that this needs to be set to exhaustive for the breakpad
Our workload / exploration strategy situation is a bit of a mess. The only workload that ever gets run in Jenkins is functional-query. When we say our Jenkins jobs run "exhaustive", what that really means is "exhaustive functional-query". If you look at L158-159 in the base you'll see this. The breakpad tests aren't running because they're part of the functional-query workload, but we don't pass the --workload_exploration_strategy functional-query:$EXPLORATION_STRATEGY (or any other) arguments to run-custom-cluster.sh. I simply moved some code around and made sure the py.test arguments get passed to all py.test runners.
Ironing out the workload situation, and the separate custom-cluster-tests.sh script, seemed out of scope for 2.6.0, but this little move seemed reasonable for 2.6.0.
If it would help, let me know if I should move some of this explanation into the commit message.
--
To view, visit http://gerrit.cloudera.org:8080/3307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3630: forward end-to-end test arguments to custom cluster tests
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-3630: forward end-to-end test arguments to custom cluster tests
......................................................................
Patch Set 8: Code-Review+2
rebase, carry +2
--
To view, visit http://gerrit.cloudera.org:8080/3307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
Gerrit-PatchSet: 8
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Silvius Rus <sr...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-2.6.0 5.8.0) preview IMPALA-3630: forward end-to-end test arguments to custom cluster tests
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: preview IMPALA-3630: forward end-to-end test arguments to custom cluster tests
......................................................................
Patch Set 4:
This is a preview in the sense that I need to put it through its Jenkins paces before even trying to GVM it.
Also, its parent commit is from https://gerrit.cloudera.org/#/c/3265/ . Until that is submitted, this patch will have no effect.
--
To view, visit http://gerrit.cloudera.org:8080/3307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-2.6.0 5.8.0) preview IMPALA-3630: forward end-to-end test arguments to custom cluster tests
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: preview IMPALA-3630: forward end-to-end test arguments to custom cluster tests
......................................................................
Patch Set 5:
(3 comments)
Lars, see patch set 5.
Also, Jenkins has trouble with breakpad tests, so this is still a preview.
http://sandbox.jenkins.cloudera.com/job/impala-umbrella-build-and-test/1403/
http://sandbox.jenkins.cloudera.com/job/impala-umbrella-build-and-test/1404/
http://gerrit.cloudera.org:8080/#/c/3307/4/bin/run-all-tests.sh
File bin/run-all-tests.sh:
PS4, Line 89: exploration_strategy
> Thanks for the explanation. It's indeed a bit confusing, as I usually add -
It's not clear to me how someone would know to find information on how to call run-tests.py written in run-all-tests.sh. It seems like we'd be better benefited by some document explaining ways to run tests, say in a README.md or somesuch. I'd prefer that be a separate Jira issue. Let me know if this is OK.
Line 160: if ! ${IMPALA_HOME}/tests/run-tests.py ${COMMON_PYTEST_ARGS} ${EE_TEST_FILES}; then
> single line?
Done
Line 194: fi
> single line?
Done
--
To view, visit http://gerrit.cloudera.org:8080/3307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-2.6.0 5.8.0) preview IMPALA-3630: forward end-to-end test arguments to custom cluster tests
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: preview IMPALA-3630: forward end-to-end test arguments to custom cluster tests
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3307/4/bin/run-all-tests.sh
File bin/run-all-tests.sh:
PS4, Line 89: exploration_strategy
> Our workload / exploration strategy situation is a bit of a mess. The only
Thanks for the explanation. It's indeed a bit confusing, as I usually add --exploration_strategy=exhaustive to the run-tests.py when launching the breakpad test. Maybe you could add it as a comment to the top of this file until it will be cleaned up?
Line 160: if ! ${IMPALA_HOME}/tests/run-tests.py \
single line?
Line 194: ${COMMON_PYTEST_ARGS}; then
single line?
--
To view, visit http://gerrit.cloudera.org:8080/3307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3630: forward end-to-end test arguments to custom cluster tests
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has submitted this change and it was merged.
Change subject: IMPALA-3630: forward end-to-end test arguments to custom cluster tests
......................................................................
IMPALA-3630: forward end-to-end test arguments to custom cluster tests
The breakpad custom cluster tests expect to run in exhaustive only, but
the option to do that isn't passed appropriately. That means they aren't
being run at all in Jenkins.
Fix the problem by setting a common set of arguments in run-all-tests.sh
and passing them along as needed.
Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
Reviewed-on: http://gerrit.cloudera.org:8080/3307
Reviewed-by: Silvius Rus <sr...@cloudera.com>
Reviewed-by: Michael Brown <mi...@cloudera.com>
Tested-by: Michael Brown <mi...@cloudera.com>
---
M bin/run-all-tests.sh
1 file changed, 14 insertions(+), 15 deletions(-)
Approvals:
Michael Brown: Looks good to me, approved; Verified
Silvius Rus: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/3307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
Gerrit-PatchSet: 9
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Silvius Rus <sr...@cloudera.com>
[Impala-CR](cdh5-2.6.0 5.8.0) preview IMPALA-3630: forward end-to-end test arguments to custom cluster tests
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: preview IMPALA-3630: forward end-to-end test arguments to custom cluster tests
......................................................................
Patch Set 6:
rebase
--
To view, visit http://gerrit.cloudera.org:8080/3307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-2.6.0 5.8.0) preview IMPALA-3630: forward end-to-end test arguments to custom cluster tests
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has uploaded a new patch set (#6).
Change subject: preview IMPALA-3630: forward end-to-end test arguments to custom cluster tests
......................................................................
preview IMPALA-3630: forward end-to-end test arguments to custom cluster tests
The breakpad custom cluster tests expect to run in exhaustive only, but
the option to do that isn't passed appropriately. That means they aren't
being run at all in Jenkins.
Fix the problem by setting a common set of arguments in run-all-tests.sh
and passing them along as needed.
Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
---
M bin/run-all-tests.sh
1 file changed, 14 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/07/3307/6
--
To view, visit http://gerrit.cloudera.org:8080/3307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3630: forward end-to-end test arguments to custom cluster tests
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-3630: forward end-to-end test arguments to custom cluster tests
......................................................................
Patch Set 7: Verified+1
This has passed private core, and private exhaustive only fails with IMPALA-3684 and IMPALA-3693. Moreover, more exhaustive tests get run and are passing, especially in the admission control custom cluster tests. I also "regression tested" by making sure there wasn't some massive decrease in tests run, passed, failing, xfailing, etc. in other areas. We're fine.
--
To view, visit http://gerrit.cloudera.org:8080/3307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
Gerrit-PatchSet: 7
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3630: forward end-to-end test arguments to custom cluster tests
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-3630: forward end-to-end test arguments to custom cluster tests
......................................................................
Patch Set 7:
Commit message updated; this is no longer a preview.
I'm running a few private Jenkins job to make sure everything else is working, and the failing breakpad tests are accounted for in IMPALA-3684.
--
To view, visit http://gerrit.cloudera.org:8080/3307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
Gerrit-PatchSet: 7
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3630: forward end-to-end test arguments to custom cluster tests
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has uploaded a new patch set (#7).
Change subject: IMPALA-3630: forward end-to-end test arguments to custom cluster tests
......................................................................
IMPALA-3630: forward end-to-end test arguments to custom cluster tests
The breakpad custom cluster tests expect to run in exhaustive only, but
the option to do that isn't passed appropriately. That means they aren't
being run at all in Jenkins.
Fix the problem by setting a common set of arguments in run-all-tests.sh
and passing them along as needed.
Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
---
M bin/run-all-tests.sh
1 file changed, 14 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/07/3307/7
--
To view, visit http://gerrit.cloudera.org:8080/3307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
Gerrit-PatchSet: 7
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3630: forward end-to-end test arguments to custom cluster tests
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-3630: forward end-to-end test arguments to custom cluster tests
......................................................................
Patch Set 8: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
Gerrit-PatchSet: 8
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Silvius Rus <sr...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3630: forward end-to-end test arguments to custom cluster tests
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-3630: forward end-to-end test arguments to custom cluster tests
......................................................................
Patch Set 7:
I checked this out and validated a potential fix for the breakpad tests on top of it.
--
To view, visit http://gerrit.cloudera.org:8080/3307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
Gerrit-PatchSet: 7
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-2.6.0 5.8.0) preview IMPALA-3630: forward end-to-end test arguments to custom cluster tests
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has uploaded a new patch set (#5).
Change subject: preview IMPALA-3630: forward end-to-end test arguments to custom cluster tests
......................................................................
preview IMPALA-3630: forward end-to-end test arguments to custom cluster tests
The breakpad custom cluster tests expect to run in exhaustive only, but
the option to do that isn't passed appropriately. That means they aren't
being run at all in Jenkins.
Fix the problem by setting a common set of arguments in run-all-tests.sh
and passing them along as needed.
Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
---
M bin/run-all-tests.sh
1 file changed, 14 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/07/3307/5
--
To view, visit http://gerrit.cloudera.org:8080/3307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3630: forward end-to-end test arguments to custom cluster tests
Posted by "Silvius Rus (Code Review)" <ge...@cloudera.org>.
Silvius Rus has posted comments on this change.
Change subject: IMPALA-3630: forward end-to-end test arguments to custom cluster tests
......................................................................
Patch Set 8: Code-Review+2
Approved by gatekeeper. Test-only change.
--
To view, visit http://gerrit.cloudera.org:8080/3307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
Gerrit-PatchSet: 8
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Silvius Rus <sr...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3630: forward end-to-end test arguments to custom cluster tests
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-3630: forward end-to-end test arguments to custom cluster tests
......................................................................
Patch Set 8:
Latest verification is http://sandbox.jenkins.cloudera.com/job/impala-umbrella-build-and-test/1576/
--
To view, visit http://gerrit.cloudera.org:8080/3307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
Gerrit-PatchSet: 8
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Silvius Rus <sr...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-2.6.0 5.8.0) preview IMPALA-3630: forward end-to-end test arguments to custom cluster tests
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: preview IMPALA-3630: forward end-to-end test arguments to custom cluster tests
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3307/4/bin/run-all-tests.sh
File bin/run-all-tests.sh:
PS4, Line 89: exploration_strategy
My assumption was, that this needs to be set to exhaustive for the breakpad tests to run. Am I wrong?
--
To view, visit http://gerrit.cloudera.org:8080/3307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3630: forward end-to-end test arguments to custom cluster tests
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-3630: forward end-to-end test arguments to custom cluster tests
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
Gerrit-PatchSet: 7
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No