You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "winterhazel (via GitHub)" <gi...@apache.org> on 2023/12/08 19:11:32 UTC
[PR] Allow locking and unlocking users via UI [cloudstack]
winterhazel opened a new pull request, #8337:
URL: https://github.com/apache/cloudstack/pull/8337
### Description
Admins are able to lock and unlock users through the APIs `lockUser` and `enableUser`; however, this feature is not currently available in the UI. To address this issue, this PR adds a button to the page of `Enabled` users which allows admins to lock them through the UI. Furthermore, when a user is `Locked`, the "Enable User" button is now visible for admins.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
### Screenshots (if appropriate):
### How Has This Been Tested?
1. In the root admin account, I accessed the page of an `Enabled` user and verified that the "Lock User" button was available;
2. I clicked the "Lock User" button and verified that the user's state changed to `Locked`;
3. I verified that the "Enable User" button was now visible.
4. I clicked the "Enable User" button and verified that the user's state changed to `Enabled`;
5. In an account that had the role `User`, I accessed the user's own page and verified that the "Lock User" button was not visible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow locking and unlocking users via UI [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8337:
URL: https://github.com/apache/cloudstack/pull/8337#issuecomment-1847763537
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow locking and unlocking users via UI [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8337:
URL: https://github.com/apache/cloudstack/pull/8337#issuecomment-1847762368
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow locking and unlocking users via UI [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #8337:
URL: https://github.com/apache/cloudstack/pull/8337#discussion_r1428774831
##########
ui/src/config/section/user.js:
##########
@@ -96,6 +96,19 @@ export default {
record.state === 'enabled'
}
},
+ {
+ api: 'lockUser',
+ icon: 'LockOutlined',
+ label: 'label.action.lock.user',
+ dataView: true,
+ popup: true,
+ show: (record, store) => {
+ return ['Admin', 'DomainAdmin'].includes(store.userInfo.roletype) && !record.isdefault &&
+ !(record.domain === 'ROOT' && record.account === 'admin' && record.accounttype === 1) &&
+ record.state === 'enabled'
+ },
+ component: shallowRef(defineAsyncComponent(() => import('@/views/iam/LockUser.vue')))
Review Comment:
That makes sense @winterhazel , but on second though, should we maybe extend the existing component instead? just a though, no :-1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow locking and unlocking users via UI [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8337:
URL: https://github.com/apache/cloudstack/pull/8337#issuecomment-1940465487
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow locking and unlocking users via UI [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8337:
URL: https://github.com/apache/cloudstack/pull/8337#issuecomment-1940478138
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8337 (QA-JID-279)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow locking and unlocking users via UI [cloudstack]
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #8337:
URL: https://github.com/apache/cloudstack/pull/8337#issuecomment-1862585778
> code looks good @winterhazel . @JoaoJandre , did you test the new functionality exclusively or poke around for regressions as well?
@DaanHoogland sorry for not explaining my tests.
1. Create a new account through the UI and then lock it through the UI;
2. Try to log in with it, the UI displays a message saying that the account was locked;
3. Unlock the account through the UI;
4. Log in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow locking and unlocking users via UI [cloudstack]
Posted by "winterhazel (via GitHub)" <gi...@apache.org>.
winterhazel commented on code in PR #8337:
URL: https://github.com/apache/cloudstack/pull/8337#discussion_r1430463427
##########
ui/src/config/section/user.js:
##########
@@ -96,6 +96,19 @@ export default {
record.state === 'enabled'
}
},
+ {
+ api: 'lockUser',
+ icon: 'LockOutlined',
+ label: 'label.action.lock.user',
+ dataView: true,
+ popup: true,
+ show: (record, store) => {
+ return ['Admin', 'DomainAdmin'].includes(store.userInfo.roletype) && !record.isdefault &&
+ !(record.domain === 'ROOT' && record.account === 'admin' && record.accounttype === 1) &&
+ record.state === 'enabled'
+ },
+ component: shallowRef(defineAsyncComponent(() => import('@/views/iam/LockUser.vue')))
Review Comment:
@DaanHoogland this seems like the optimal solution, as it would allow easily doing the same thing in other parts of the UI. Since this feature would prove useful to this PR, I will try implementing it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow locking and unlocking users via UI [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8337:
URL: https://github.com/apache/cloudstack/pull/8337#issuecomment-1862275877
code looks good @winterhazel .
@JoaoJandre , did you test the new functionality exclusively or poke around for regressions as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow locking and unlocking users via UI [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8337:
URL: https://github.com/apache/cloudstack/pull/8337#issuecomment-1862714349
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow locking and unlocking users via UI [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8337:
URL: https://github.com/apache/cloudstack/pull/8337#issuecomment-1847781266
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8337 (QA-JID-245)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow locking and unlocking users via UI [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #8337:
URL: https://github.com/apache/cloudstack/pull/8337#issuecomment-1940464950
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow locking and unlocking users via UI [cloudstack]
Posted by "winterhazel (via GitHub)" <gi...@apache.org>.
winterhazel commented on PR #8337:
URL: https://github.com/apache/cloudstack/pull/8337#issuecomment-1892520446
@DaanHoogland thanks for testing, but ideally this is not enough regarding the changes in `AutogenView.vue`.
There are different ways in which labels are shown and provided to confirmation dialogs, and this only tests some of these. As all of the existing ways have been affected, I would appreciate if we validated that all of them are still working as before (and therefore, that every dialog is still being shown as expected).
Here is everything that has been affected and how it can be validated below:
1. How the `message` can be presented:
a. When bulk deleting/powering off a resource (line 186)
b. When bulk doing something other than deleting/powering off a resource (line 192)
c. Every other situation (line 199)
2. How `message`s can be inserted into actions:
a. Providing just a label;
b. Providing a function that returns a label;
c. Providing a function that returns an array.
3. How `successMessage`s can be inserted into actions:
a. Providing just a label;
b. Providing a function that returns a label;
c. Providing a function that returns an array;
d. Not providing anything (a generic success message is used).
4. Providing a label in the `additionalMessage` param.
Please feel free to point if I missed something. Here's how to test all these things:
1. Bulk deleting some VMs. This tests 1a and 2a.
2. Bulk restarting some networks. This tests 1b.
3. Archiving an event. This tests 1c and 3a.
4. Locking a user. This tests 2c and 3c.
5. Disabling a user's 2FA. This tests 2b and 3d.
6. The `additionalMessage` is only used when updating a VMware data center. If an environment with VMware is unavailable, an option to test it is by just inserting the `additionalMessage` param into any action. This tests 4.
7. 3b is not used anywhere, so we can just change any existing `successMessage` into a function that returns a label and verify it is working.
I have tested all of those and verified they are still working as expected, but I would appreciate if someone else could also verify them.
---
Also pinging @JoaoJandre @shwstppr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow locking and unlocking users via UI [cloudstack]
Posted by "winterhazel (via GitHub)" <gi...@apache.org>.
winterhazel commented on code in PR #8337:
URL: https://github.com/apache/cloudstack/pull/8337#discussion_r1428224671
##########
ui/src/config/section/user.js:
##########
@@ -96,6 +96,19 @@ export default {
record.state === 'enabled'
}
},
+ {
+ api: 'lockUser',
+ icon: 'LockOutlined',
+ label: 'label.action.lock.user',
+ dataView: true,
+ popup: true,
+ show: (record, store) => {
+ return ['Admin', 'DomainAdmin'].includes(store.userInfo.roletype) && !record.isdefault &&
+ !(record.domain === 'ROOT' && record.account === 'admin' && record.accounttype === 1) &&
+ record.state === 'enabled'
+ },
+ component: shallowRef(defineAsyncComponent(() => import('@/views/iam/LockUser.vue')))
Review Comment:
There is. I created this component because I thought it would be nice to include the user's name in the warning and success messages so that operators do not accidentally lock the wrong user and so that they get a confirmation showing which user was locked, which was not possible with the existing mechanism since it does not provide the option to replace placeholders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow locking and unlocking users via UI [cloudstack]
Posted by "winterhazel (via GitHub)" <gi...@apache.org>.
winterhazel commented on code in PR #8337:
URL: https://github.com/apache/cloudstack/pull/8337#discussion_r1430513885
##########
ui/src/config/section/user.js:
##########
@@ -96,6 +96,19 @@ export default {
record.state === 'enabled'
}
},
+ {
+ api: 'lockUser',
+ icon: 'LockOutlined',
+ label: 'label.action.lock.user',
+ dataView: true,
+ popup: true,
+ show: (record, store) => {
+ return ['Admin', 'DomainAdmin'].includes(store.userInfo.roletype) && !record.isdefault &&
+ !(record.domain === 'ROOT' && record.account === 'admin' && record.accounttype === 1) &&
+ record.state === 'enabled'
+ },
+ component: shallowRef(defineAsyncComponent(() => import('@/views/iam/LockUser.vue')))
Review Comment:
@DaanHoogland @shwstppr I have made some changes in this PR to allow the replacement of placeholders in `message`s and `successMessage`s of confirmation dialogs, and updated the description. Could you guys review again? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow locking and unlocking users via UI [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8337:
URL: https://github.com/apache/cloudstack/pull/8337#issuecomment-1862712934
> > code looks good @winterhazel . @JoaoJandre , did you test the new functionality exclusively or poke around for regressions as well?
>
> @DaanHoogland sorry for not explaining my tests.
>
> 1. Create a new account through the UI and then lock it through the UI;
>
> 2. Try to log in with it, the UI displays a message saying that the account was locked;
>
> 3. Unlock the account through the UI;
>
> 4. Log in.
That is no problem, just making sure we know what the status is. These I had tested as well, without explaining in https://github.com/apache/cloudstack/pull/8337#pullrequestreview-1777122461 (/me equaly guilty)
My point is that the scope has increased and we now also need to test some other dialog (pluralis majestatis used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow locking and unlocking users via UI [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8337:
URL: https://github.com/apache/cloudstack/pull/8337#issuecomment-1847696334
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8337?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `16 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`4e9c4a5`)](https://app.codecov.io/gh/apache/cloudstack/commit/4e9c4a5895b30179bc9e1701d81a37a370990ede?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 29.12% compared to head [(`ca18cef`)](https://app.codecov.io/gh/apache/cloudstack/pull/8337?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 4.42%.
> Report is 8 commits behind head on main.
| [Files](https://app.codecov.io/gh/apache/cloudstack/pull/8337?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [ui/src/views/iam/LockUser.vue](https://app.codecov.io/gh/apache/cloudstack/pull/8337?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dWkvc3JjL3ZpZXdzL2lhbS9Mb2NrVXNlci52dWU=) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8337?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [ui/src/config/section/user.js](https://app.codecov.io/gh/apache/cloudstack/pull/8337?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dWkvc3JjL2NvbmZpZy9zZWN0aW9uL3VzZXIuanM=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8337?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8337 +/- ##
============================================
- Coverage 29.12% 4.42% -24.71%
============================================
Files 5260 362 -4898
Lines 369710 28406 -341304
Branches 53890 4954 -48936
============================================
- Hits 107678 1256 -106422
+ Misses 247276 27012 -220264
+ Partials 14756 138 -14618
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8337/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8337/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8337/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.42% <0.00%> (-0.01%)` | :arrow_down: |
| [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8337/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8337?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow locking and unlocking users via UI [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on code in PR #8337:
URL: https://github.com/apache/cloudstack/pull/8337#discussion_r1427899436
##########
ui/src/config/section/user.js:
##########
@@ -96,6 +96,19 @@ export default {
record.state === 'enabled'
}
},
+ {
+ api: 'lockUser',
+ icon: 'LockOutlined',
+ label: 'label.action.lock.user',
+ dataView: true,
+ popup: true,
+ show: (record, store) => {
+ return ['Admin', 'DomainAdmin'].includes(store.userInfo.roletype) && !record.isdefault &&
+ !(record.domain === 'ROOT' && record.account === 'admin' && record.accounttype === 1) &&
+ record.state === 'enabled'
+ },
+ component: shallowRef(defineAsyncComponent(() => import('@/views/iam/LockUser.vue')))
Review Comment:
@winterhazel I'm not sure but isn't there a mechanism already to show a confirm dialog with custom text? I guess that's all this new vue component is doing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow locking and unlocking users via UI [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8337:
URL: https://github.com/apache/cloudstack/pull/8337#issuecomment-1862713411
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow locking and unlocking users via UI [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8337:
URL: https://github.com/apache/cloudstack/pull/8337#issuecomment-1862749094
I created and deleted a user in the ui and the notification message appeared:
I am actually not sure if this is enough. Could you tell @shwstppr ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow locking and unlocking users via UI [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8337:
URL: https://github.com/apache/cloudstack/pull/8337#issuecomment-1862737961
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8337 (QA-JID-248)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow locking and unlocking users via UI [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8337:
URL: https://github.com/apache/cloudstack/pull/8337#issuecomment-1940901650
works in qa, no backend code so the GHA failure can't be related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow locking and unlocking users via UI [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #8337:
URL: https://github.com/apache/cloudstack/pull/8337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org