You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@oozie.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2011/09/08 06:25:10 UTC

[jira] [Created] (OOZIE-81) GH-40: coordinator rerun doesn't consider empty output-event

GH-40: coordinator rerun doesn't consider empty output-event
------------------------------------------------------------

                 Key: OOZIE-81
                 URL: https://issues.apache.org/jira/browse/OOZIE-81
             Project: Oozie
          Issue Type: Bug
            Reporter: Hadoop QA


### User experience:

If the user selects cleanup but there is no "output-event" in the cooridnator xml, the code will throw NullPointerException (NPE):

    private void cleanupOutputEvents(Element eAction, String user, String group) {
            Element outputList = eAction.getChild("output-events", eAction.getNamespace());
            for (Element data : (List) outputList.getChildren("data-out", eAction.getNamespace())) {

Line 3 will throw NPE.

Solution:

    if (outputList != null) {
        for (Element data : (List) outputList.getChildren("data-out", eAction.getNamespace())) {
         ......
    }

### Additional activities:

1. Add an unit test
2. QA needs to add one test case with this scenario.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OOZIE-81) GH-40: coordinator rerun doesn't consider empty output-event

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OOZIE-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099780#comment-13099780 ] 

Hadoop QA commented on OOZIE-81:
--------------------------------

rvs remarked:
Closed by f337f6383090710575b345f48e8b2539339e698d coordinator rerun doesn't consider empty output-event

> GH-40: coordinator rerun doesn't consider empty output-event
> ------------------------------------------------------------
>
>                 Key: OOZIE-81
>                 URL: https://issues.apache.org/jira/browse/OOZIE-81
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Hadoop QA
>
> ### User experience:
> If the user selects cleanup but there is no "output-event" in the cooridnator xml, the code will throw NullPointerException (NPE):
>     private void cleanupOutputEvents(Element eAction, String user, String group) {
>             Element outputList = eAction.getChild("output-events", eAction.getNamespace());
>             for (Element data : (List) outputList.getChildren("data-out", eAction.getNamespace())) {
> Line 3 will throw NPE.
> Solution:
>     if (outputList != null) {
>         for (Element data : (List) outputList.getChildren("data-out", eAction.getNamespace())) {
>          ......
>     }
> ### Additional activities:
> 1. Add an unit test
> 2. QA needs to add one test case with this scenario.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (OOZIE-81) GH-40: coordinator rerun doesn't consider empty output-event

Posted by "Roman Shaposhnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OOZIE-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roman Shaposhnik closed OOZIE-81.
---------------------------------

    Resolution: Fixed

> GH-40: coordinator rerun doesn't consider empty output-event
> ------------------------------------------------------------
>
>                 Key: OOZIE-81
>                 URL: https://issues.apache.org/jira/browse/OOZIE-81
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Hadoop QA
>
> ### User experience:
> If the user selects cleanup but there is no "output-event" in the cooridnator xml, the code will throw NullPointerException (NPE):
>     private void cleanupOutputEvents(Element eAction, String user, String group) {
>             Element outputList = eAction.getChild("output-events", eAction.getNamespace());
>             for (Element data : (List) outputList.getChildren("data-out", eAction.getNamespace())) {
> Line 3 will throw NPE.
> Solution:
>     if (outputList != null) {
>         for (Element data : (List) outputList.getChildren("data-out", eAction.getNamespace())) {
>          ......
>     }
> ### Additional activities:
> 1. Add an unit test
> 2. QA needs to add one test case with this scenario.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira