[GitHub] eolivelli commented on a change in pull request #817: Client times out requests in batch rather than individually

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #817: Client times out requests in batch rather than individually
URL: https://github.com/apache/bookkeeper/pull/817#discussion_r155223785
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
 ##########
 @@ -1371,6 +1389,16 @@ void handleUnrecoverableErrorDuringAdd(int rc) {
         asyncCloseInternal(NoopCloseCallback.instance, null, rc);
     }
 
+    void monitorPendingAddOps() {
+        int timedOut = 0;
+        for (PendingAddOp op : pendingAddOps) {
+            if (op.maybeTimeout()) {
+                timedOut++;
+            }
+        }
+        LOG.info("Timed out {} add ops", timedOut);
 
 Review comment:
   maybe it is better to log this only if timedOut > 0, otherwise we will spam logs at INFO level

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services