You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/04/12 03:20:21 UTC
[GitHub] [thrift] Jimexist opened a new pull request, #2560: apply clang-format to java generator
Jimexist opened a new pull request, #2560:
URL: https://github.com/apache/thrift/pull/2560
<!-- Explain the changes in the pull request below: -->
apply clang-format to java generator
steps:
```bash
apt install clang-format
clang-format -i <file>
```
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but preferred)
- [ ] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] ctubbsii commented on pull request #2560: THRIFT-5552: apply clang-format to java generator
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on PR #2560:
URL: https://github.com/apache/thrift/pull/2560#issuecomment-1095955099
The CI tasks seem completely stalled... queued for 30 minutes, not even beginning to run. I built locally without libs to confirm that the generator still compiles fine, that these changes are purely cosmetic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] ctubbsii commented on pull request #2560: THRIFT-5552: apply clang-format to java generator
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on PR #2560:
URL: https://github.com/apache/thrift/pull/2560#issuecomment-1095939454
Apparently there's a `make style` target... it's even in the [CONTRIBUTING.md] and contributor documentation on the website. I guess nobody runs it very often... because lots of stuff are way off. This PR only fixes it for one file... which is fine. I confirmed that this file conforms to the `make style` output after this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] ctubbsii merged pull request #2560: THRIFT-5552: apply clang-format to java generator
Posted by GitBox <gi...@apache.org>.
ctubbsii merged PR #2560:
URL: https://github.com/apache/thrift/pull/2560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org