You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (Created) (JIRA)" <ji...@apache.org> on 2012/03/22 16:16:23 UTC
[jira] [Created] (LUCENE-3903) javadocs very very ugly if you
generate with java7
javadocs very very ugly if you generate with java7
--------------------------------------------------
Key: LUCENE-3903
URL: https://issues.apache.org/jira/browse/LUCENE-3903
Project: Lucene - Java
Issue Type: Bug
Components: general/javadocs
Affects Versions: 3.6, 4.0
Reporter: Robert Muir
Java7 changes its javadocs to look much nicer, but this involves different CSS styles.
Lucene overrides the CSS with stylesheet+prettify.css which is a combination of java5/6 stylesheet + google prettify:
but there are problems because java7 has totally different styles.
So if you generate javadocs with java7, its like you have no stylesheet at all.
A solution might be to make stylesheet7+prettify.css and conditionalize a property in ant based on java version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3903) javadocs very very ugly if you
generate with java7
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235812#comment-13235812 ]
Robert Muir commented on LUCENE-3903:
-------------------------------------
Thanks Uwe!
> javadocs very very ugly if you generate with java7
> --------------------------------------------------
>
> Key: LUCENE-3903
> URL: https://issues.apache.org/jira/browse/LUCENE-3903
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/javadocs
> Affects Versions: 3.6, 4.0
> Reporter: Robert Muir
> Assignee: Uwe Schindler
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3903.patch, LUCENE-3903.patch, LUCENE-3903.patch, java7docs.jpg
>
>
> Java7 changes its javadocs to look much nicer, but this involves different CSS styles.
> Lucene overrides the CSS with stylesheet+prettify.css which is a combination of java5/6 stylesheet + google prettify:
> but there are problems because java7 has totally different styles.
> So if you generate javadocs with java7, its like you have no stylesheet at all.
> A solution might be to make stylesheet7+prettify.css and conditionalize a property in ant based on java version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3903) javadocs very very ugly if you
generate with java7
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235735#comment-13235735 ]
Robert Muir commented on LUCENE-3903:
-------------------------------------
+1
Tested on branch_3x with Java5, 6, and 7 (just patch --merge)
> javadocs very very ugly if you generate with java7
> --------------------------------------------------
>
> Key: LUCENE-3903
> URL: https://issues.apache.org/jira/browse/LUCENE-3903
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/javadocs
> Affects Versions: 3.6, 4.0
> Reporter: Robert Muir
> Assignee: Uwe Schindler
> Attachments: LUCENE-3903.patch, java7docs.jpg
>
>
> Java7 changes its javadocs to look much nicer, but this involves different CSS styles.
> Lucene overrides the CSS with stylesheet+prettify.css which is a combination of java5/6 stylesheet + google prettify:
> but there are problems because java7 has totally different styles.
> So if you generate javadocs with java7, its like you have no stylesheet at all.
> A solution might be to make stylesheet7+prettify.css and conditionalize a property in ant based on java version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Assigned] (LUCENE-3903) javadocs very very ugly if you
generate with java7
Posted by "Uwe Schindler (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler reassigned LUCENE-3903:
-------------------------------------
Assignee: Uwe Schindler
> javadocs very very ugly if you generate with java7
> --------------------------------------------------
>
> Key: LUCENE-3903
> URL: https://issues.apache.org/jira/browse/LUCENE-3903
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/javadocs
> Affects Versions: 3.6, 4.0
> Reporter: Robert Muir
> Assignee: Uwe Schindler
> Attachments: LUCENE-3903.patch, java7docs.jpg
>
>
> Java7 changes its javadocs to look much nicer, but this involves different CSS styles.
> Lucene overrides the CSS with stylesheet+prettify.css which is a combination of java5/6 stylesheet + google prettify:
> but there are problems because java7 has totally different styles.
> So if you generate javadocs with java7, its like you have no stylesheet at all.
> A solution might be to make stylesheet7+prettify.css and conditionalize a property in ant based on java version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3903) javadocs very very ugly if you
generate with java7
Posted by "Robert Muir (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-3903:
--------------------------------
Attachment: java7docs.jpg
> javadocs very very ugly if you generate with java7
> --------------------------------------------------
>
> Key: LUCENE-3903
> URL: https://issues.apache.org/jira/browse/LUCENE-3903
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/javadocs
> Affects Versions: 3.6, 4.0
> Reporter: Robert Muir
> Attachments: java7docs.jpg
>
>
> Java7 changes its javadocs to look much nicer, but this involves different CSS styles.
> Lucene overrides the CSS with stylesheet+prettify.css which is a combination of java5/6 stylesheet + google prettify:
> but there are problems because java7 has totally different styles.
> So if you generate javadocs with java7, its like you have no stylesheet at all.
> A solution might be to make stylesheet7+prettify.css and conditionalize a property in ant based on java version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3903) javadocs very very ugly if you
generate with java7
Posted by "Uwe Schindler (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-3903:
----------------------------------
Attachment: LUCENE-3903.patch
Minor tweaks:
- Moved the javascript into <bottom>, as its then not duplicated multiple times
- fixed attributes corrumption in the CDATA.
I will commit this later!
> javadocs very very ugly if you generate with java7
> --------------------------------------------------
>
> Key: LUCENE-3903
> URL: https://issues.apache.org/jira/browse/LUCENE-3903
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/javadocs
> Affects Versions: 3.6, 4.0
> Reporter: Robert Muir
> Assignee: Uwe Schindler
> Attachments: LUCENE-3903.patch, LUCENE-3903.patch, java7docs.jpg
>
>
> Java7 changes its javadocs to look much nicer, but this involves different CSS styles.
> Lucene overrides the CSS with stylesheet+prettify.css which is a combination of java5/6 stylesheet + google prettify:
> but there are problems because java7 has totally different styles.
> So if you generate javadocs with java7, its like you have no stylesheet at all.
> A solution might be to make stylesheet7+prettify.css and conditionalize a property in ant based on java version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3903) javadocs very very ugly if you
generate with java7
Posted by "Uwe Schindler (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler resolved LUCENE-3903.
-----------------------------------
Resolution: Fixed
Fix Version/s: 4.0
3.6
Committed trunk revision: 1303916
Committed 3.x revision: 1303922
> javadocs very very ugly if you generate with java7
> --------------------------------------------------
>
> Key: LUCENE-3903
> URL: https://issues.apache.org/jira/browse/LUCENE-3903
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/javadocs
> Affects Versions: 3.6, 4.0
> Reporter: Robert Muir
> Assignee: Uwe Schindler
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3903.patch, LUCENE-3903.patch, LUCENE-3903.patch, java7docs.jpg
>
>
> Java7 changes its javadocs to look much nicer, but this involves different CSS styles.
> Lucene overrides the CSS with stylesheet+prettify.css which is a combination of java5/6 stylesheet + google prettify:
> but there are problems because java7 has totally different styles.
> So if you generate javadocs with java7, its like you have no stylesheet at all.
> A solution might be to make stylesheet7+prettify.css and conditionalize a property in ant based on java version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3903) javadocs very very ugly if you
generate with java7
Posted by "Uwe Schindler (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-3903:
----------------------------------
Attachment: LUCENE-3903.patch
Robert and me noticed a small issue: Javadoc does not regenerate the stylesheet, if its already there. This leads to appending the same prettyprint.css all the time. I added a delete for this file before running javadocs, so its regenerated.
Now its final :-)
> javadocs very very ugly if you generate with java7
> --------------------------------------------------
>
> Key: LUCENE-3903
> URL: https://issues.apache.org/jira/browse/LUCENE-3903
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/javadocs
> Affects Versions: 3.6, 4.0
> Reporter: Robert Muir
> Assignee: Uwe Schindler
> Attachments: LUCENE-3903.patch, LUCENE-3903.patch, LUCENE-3903.patch, java7docs.jpg
>
>
> Java7 changes its javadocs to look much nicer, but this involves different CSS styles.
> Lucene overrides the CSS with stylesheet+prettify.css which is a combination of java5/6 stylesheet + google prettify:
> but there are problems because java7 has totally different styles.
> So if you generate javadocs with java7, its like you have no stylesheet at all.
> A solution might be to make stylesheet7+prettify.css and conditionalize a property in ant based on java version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3903) javadocs very very ugly if you
generate with java7
Posted by "Uwe Schindler (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-3903:
----------------------------------
Attachment: LUCENE-3903.patch
Patch that fixes the issue(s):
- Simply append the pretify.css to the one created by javadocs itsself (as post-javadoc-task <concat/>)
- Fix javascript issues by Java 7: The code that triggered prettyprint was relying on an implementation specific javascript function name no longer existent in Java 7. I changed the window.onload handler to dynamically append the 2nd handler.
> javadocs very very ugly if you generate with java7
> --------------------------------------------------
>
> Key: LUCENE-3903
> URL: https://issues.apache.org/jira/browse/LUCENE-3903
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/javadocs
> Affects Versions: 3.6, 4.0
> Reporter: Robert Muir
> Attachments: LUCENE-3903.patch, java7docs.jpg
>
>
> Java7 changes its javadocs to look much nicer, but this involves different CSS styles.
> Lucene overrides the CSS with stylesheet+prettify.css which is a combination of java5/6 stylesheet + google prettify:
> but there are problems because java7 has totally different styles.
> So if you generate javadocs with java7, its like you have no stylesheet at all.
> A solution might be to make stylesheet7+prettify.css and conditionalize a property in ant based on java version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3903) javadocs very very ugly if you
generate with java7
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235628#comment-13235628 ]
Robert Muir commented on LUCENE-3903:
-------------------------------------
I really think we should fix this for 3.6: its not just that its ugly but it looks actually broken.
> javadocs very very ugly if you generate with java7
> --------------------------------------------------
>
> Key: LUCENE-3903
> URL: https://issues.apache.org/jira/browse/LUCENE-3903
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/javadocs
> Affects Versions: 3.6, 4.0
> Reporter: Robert Muir
>
> Java7 changes its javadocs to look much nicer, but this involves different CSS styles.
> Lucene overrides the CSS with stylesheet+prettify.css which is a combination of java5/6 stylesheet + google prettify:
> but there are problems because java7 has totally different styles.
> So if you generate javadocs with java7, its like you have no stylesheet at all.
> A solution might be to make stylesheet7+prettify.css and conditionalize a property in ant based on java version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org