You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Andrea Del Bene (JIRA)" <ji...@apache.org> on 2012/07/31 23:06:34 UTC
[jira] [Created] (WICKET-4686) MountMapper does not support
correctly parameter placeholders
Andrea Del Bene created WICKET-4686:
---------------------------------------
Summary: MountMapper does not support correctly parameter placeholders
Key: WICKET-4686
URL: https://issues.apache.org/jira/browse/WICKET-4686
Project: Wicket
Issue Type: Bug
Reporter: Andrea Del Bene
Package mounting doesn't support parameter placeholders. The problem seems to be inside MountMapper which should wrap PackageMapper and take care of substituting placeholders with their actual value.
More precisely this class doesn't read parameter values from PageParameters and it's not very clear to me how it tries to read these values.
Does anybody have some hints about this class?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4686) MountMapper does not support
correctly parameter placeholders
Posted by "Andrea Del Bene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrea Del Bene updated WICKET-4686:
------------------------------------
Affects Version/s: 1.5.7
> MountMapper does not support correctly parameter placeholders
> -------------------------------------------------------------
>
> Key: WICKET-4686
> URL: https://issues.apache.org/jira/browse/WICKET-4686
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5.7
> Reporter: Andrea Del Bene
> Attachments: MountPagesIssue.zip
>
>
> Package mounting doesn't support parameter placeholders. The problem seems to be inside MountMapper which should wrap PackageMapper and take care of substituting placeholders with their actual value.
> More precisely this class doesn't read parameter values from PageParameters and it's not very clear to me how it tries to read these values.
> Does anybody have some hints about this class?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4686) MountMapper does not support
correctly parameter placeholders
Posted by "Andrea Del Bene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434172#comment-13434172 ]
Andrea Del Bene commented on WICKET-4686:
-----------------------------------------
I've done some refactoring by myself and I ended up with a solution very similar to your. I also don't like to have MountMapper not used by anyone, but I don't have any better solution so far.
> MountMapper does not support correctly parameter placeholders
> -------------------------------------------------------------
>
> Key: WICKET-4686
> URL: https://issues.apache.org/jira/browse/WICKET-4686
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5.7
> Reporter: Andrea Del Bene
> Assignee: Martin Grigorov
> Attachments: MountPagesIssue.zip
>
>
> Package mounting doesn't support parameter placeholders. The problem seems to be inside MountMapper which should wrap PackageMapper and take care of substituting placeholders with their actual value.
> More precisely this class doesn't read parameter values from PageParameters and it's not very clear to me how it tries to read these values.
> Does anybody have some hints about this class?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4686) MountMapper does not support
correctly parameter placeholders
Posted by "Andrea Del Bene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrea Del Bene updated WICKET-4686:
------------------------------------
Attachment: MountPagesIssue.zip
> MountMapper does not support correctly parameter placeholders
> -------------------------------------------------------------
>
> Key: WICKET-4686
> URL: https://issues.apache.org/jira/browse/WICKET-4686
> Project: Wicket
> Issue Type: Bug
> Reporter: Andrea Del Bene
> Attachments: MountPagesIssue.zip
>
>
> Package mounting doesn't support parameter placeholders. The problem seems to be inside MountMapper which should wrap PackageMapper and take care of substituting placeholders with their actual value.
> More precisely this class doesn't read parameter values from PageParameters and it's not very clear to me how it tries to read these values.
> Does anybody have some hints about this class?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4686) MountMapper does not support
correctly parameter placeholders
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430288#comment-13430288 ]
Martin Grigorov commented on WICKET-4686:
-----------------------------------------
I've restructured the code that handles the placeholders from MountedMapper to AbstractBookmarkableMapper and now PackageMapper doesn't need MountMapper to handle your use case.
I don't like that now MountMapper is not used at all. It should be responsible for all of this but it will be too big change - MountedMapper will require to be wrapped in MountMapper.
Check https://git-wip-us.apache.org/repos/asf/wicket/repo?p=wicket.git;a=commitdiff;h=8b4d9de39eedeef10ff1ff0a383606b6b94785bb. It is in a separate branch - sandbox/WICKET-4686.
> MountMapper does not support correctly parameter placeholders
> -------------------------------------------------------------
>
> Key: WICKET-4686
> URL: https://issues.apache.org/jira/browse/WICKET-4686
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5.7
> Reporter: Andrea Del Bene
> Assignee: Martin Grigorov
> Attachments: MountPagesIssue.zip
>
>
> Package mounting doesn't support parameter placeholders. The problem seems to be inside MountMapper which should wrap PackageMapper and take care of substituting placeholders with their actual value.
> More precisely this class doesn't read parameter values from PageParameters and it's not very clear to me how it tries to read these values.
> Does anybody have some hints about this class?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4686) MountMapper does not support
correctly parameter placeholders
Posted by "Andrea Del Bene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428648#comment-13428648 ]
Andrea Del Bene commented on WICKET-4686:
-----------------------------------------
At the moment MountMapper tries to "unmount" the URL leaving just the segment with the class name of a page, however its not trivial do identify which segment contains this value if mounted path is composed by optional placeholders.
Unfortunately I haven't find a solution so far.
> MountMapper does not support correctly parameter placeholders
> -------------------------------------------------------------
>
> Key: WICKET-4686
> URL: https://issues.apache.org/jira/browse/WICKET-4686
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5.7
> Reporter: Andrea Del Bene
> Attachments: MountPagesIssue.zip
>
>
> Package mounting doesn't support parameter placeholders. The problem seems to be inside MountMapper which should wrap PackageMapper and take care of substituting placeholders with their actual value.
> More precisely this class doesn't read parameter values from PageParameters and it's not very clear to me how it tries to read these values.
> Does anybody have some hints about this class?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WICKET-4686) MountMapper does not support
correctly parameter placeholders
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-4686:
---------------------------------------
Assignee: Martin Grigorov
> MountMapper does not support correctly parameter placeholders
> -------------------------------------------------------------
>
> Key: WICKET-4686
> URL: https://issues.apache.org/jira/browse/WICKET-4686
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5.7
> Reporter: Andrea Del Bene
> Assignee: Martin Grigorov
> Attachments: MountPagesIssue.zip
>
>
> Package mounting doesn't support parameter placeholders. The problem seems to be inside MountMapper which should wrap PackageMapper and take care of substituting placeholders with their actual value.
> More precisely this class doesn't read parameter values from PageParameters and it's not very clear to me how it tries to read these values.
> Does anybody have some hints about this class?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira