You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/05/14 11:07:08 UTC

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1203: [CALCITE-3017] Improve null handling of JsonValueExpressionOperator

zhztheplayer commented on a change in pull request #1203: [CALCITE-3017] Improve null handling of JsonValueExpressionOperator
URL: https://github.com/apache/calcite/pull/1203#discussion_r283743481
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
 ##########
 @@ -984,6 +986,8 @@ private static Expression implementNullSemantics(
         : call.getOperands();
     switch (nullAs) {
     case NULL:
+    case IS_NULL:
 
 Review comment:
   Reason of the change:
   `IS_NULL`/`IS_NOT_NULL` define the boolean return based on the nullability of original return value. The use of them should not break trivial null handling for operands.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services