[GitHub] [spark] dbtsai commented on a change in pull request #27728: [SPARK-17636][SQL] Nested Column Predicate Pushdown for Parquet

[GitBox <gi...@apache.org>]

dbtsai commented on a change in pull request #27728: [SPARK-17636][SQL] Nested Column Predicate Pushdown for Parquet
URL: https://github.com/apache/spark/pull/27728#discussion_r386739846
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Implicits.scala
 ##########
 @@ -132,4 +134,8 @@ private[sql] object CatalogV2Implicits {
       part
     }
   }
+
+  def unquote(name: String): Seq[String] = {
+    new CatalystSqlParser(SQLConf.get).parseMultipartIdentifier(name)
 
 Review comment:
   How about 
   
   ```scala
     private lazy val catalystSqlParser = new CatalystSqlParser(SQLConf.get)
   
     def unquote(name: String): Seq[String] = {
       catalystSqlParser.parseMultipartIdentifier(name)
     }
   ```
   for now until we find a good place to have an internal instance of `catalystSqlParser`?
   
   The concern is that if we have it in the singleton, what if the `SQLConf` is changed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org