Re: BindingJS test failing

[Carlos Rovira <ca...@apache.org>]

Hi Josh,

just complete my daily build and I can confirm that all finished
successfully.
If it may be of help this is the script I use to run every day to build ANT
and Maven, doing the ant cleaning to ensure ant is removed correctly:
https://gist.github.com/carlosrovira/200753108de263fa43e80d3228213509

Thanks!

Carlos


El vie., 31 jul. 2020 a las 23:21, Josh Tynjala (<jo...@bowlerhat.dev>)
escribió:

> I did a clean checkout of royale-asjs, and I can reproduce the test failure
> again. I reverted the offending commit for now, and all tests complete
> successfully again.
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://bowlerhat.dev>
>
>
> On Fri, Jul 31, 2020 at 10:43 AM Josh Tynjala <jo...@bowlerhat.dev>
> wrote:
>
> > I tried restarting my machine and doing a full build again, just in case
> > there was anything stuck in a weird state. However, I still cannot
> > reproduce this test failure on my machine. Again, it did reproduce
> > originally, but I did... something currently unknown... to make it go
> away.
> > I suspect that it involved cleaning one of the projects before building.
> >
> > I'm currently building an older commit of royale-compiler to see if I can
> > restore the state that caused the test failure. If I cannot reproduce
> > today, I'll revert the most recent commit, which is the one that triggers
> > this strange issue.
> >
> > --
> > Josh Tynjala
> > Bowler Hat LLC <https://bowlerhat.dev>
> >
> >
> > On Fri, Jul 31, 2020 at 9:27 AM Josh Tynjala <jo...@bowlerhat.dev>
> > wrote:
> >
> >> I was getting this test failure at first too, but now, it won't
> reproduce
> >> on my machine anymore. I suspect that I ran `ant clean` on everything,
> and
> >> it cleared out some old artifacts that were causing a conflict. Can you
> >> guys try cleaning?
> >>
> >> --
> >> Josh Tynjala
> >> Bowler Hat LLC <https://bowlerhat.dev>
> >>
> >>
> >> On Fri, Jul 31, 2020 at 8:10 AM Carlos Rovira <ca...@apache.org>
> >> wrote:
> >>
> >>> Hi Greg, Josh
> >>>
> >>> today the error changed to CoreJS:
> >>>
> >>> BUILD FAILED
> >>>
> >>> /Users/carlosrovira/Dev/Royale/Source/royale-asjs/build.xml:667: The
> >>> following error occurred while executing this line:
> >>>
> >>>
> >>>
> /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/build.xml:154:
> >>> The following error occurred while executing this line:
> >>>
> >>>
> >>>
> /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/build.xml:299:
> >>> The following error occurred while executing this line:
> >>>
> >>>
> >>>
> /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/projects/Core/build.xml:70:
> >>> The following error occurred while executing this line:
> >>>
> >>>
> >>>
> /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/projects/Core/build.xml:74:
> >>> The following error occurred while executing this line:
> >>>
> >>>
> >>>
> /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/js/projects/CoreJS/build.xml:54:
> >>> The following error occurred while executing this line:
> >>>
> >>>
> >>>
> /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/js/projects/CoreJS/src/test/royale/build.xml:238:
> >>> Test Failure
> >>>
> >>> RoyaleUnit Release Build Tests must pass:
> >>>
> >>>
> >>>
> >>>             CoreJS.test RoyaleUnit Release build tests: FAILED
> >>>
> >>>             CoreJS.test RoyaleUnit Debug build tests: PASSED
> >>>
> >>>
> >>> Total time: 10 minutes 25 seconds
> >>>
> >>> Error:Build stopped - build SDK with ANT
> >>>
> >>> El vie., 31 jul. 2020 a las 4:56, Greg Dove (<gr...@gmail.com>)
> >>> escribió:
> >>>
> >>> > Hi @joshtynjala@apache.org I think you might have done something to
> >>> fix
> >>> > what Carlos reported? I did not see it today via my local build.
> >>> >
> >>> > But I did see an error with this line in another test:
> >>> >
> >>> >
> >>>
> https://github.com/apache/royale-asjs/blob/d08cdff1413ad3916dbab14a9582c247f88ef2f3/frameworks/projects/Core/src/test/royale/flexUnitTests/language/LanguageTesterTestVector.as#L1358
> >>> >
> >>> > breakdown:
> >>> > protected static function get getterTest():Vector.<String> (details
> >>> > omitted)
> >>> >
> >>> > ..later:
> >>> > var vString:Vector.<String>
> >>> >
> >>> > vString = getterTest; //<-this works in debug mode but is undefined
> in
> >>> > release mode and that causes subsequent assertions to fail.
> >>> >
> >>> >
> >>> > relevant generated output:
> >>> >
> >>> >   vString =
> >>> flexUnitTests.language.LanguageTesterTestVector["getterTest"];
> >>> >
> >>> >
> >>>
> Object.defineProperties(flexUnitTests.language.LanguageTesterTestVector,
> >>> > /** @lends {flexUnitTests.language.LanguageTesterTestVector} */ {
> >>> > /**
> >>> >   * @type {Array.<string>} */
> >>> > getterTest: {
> >>> > get:
> flexUnitTests.language.LanguageTesterTestVector.get__getterTest}}
> >>> > );
> >>> >
> >>> > I am not sure what changed to make this part of the testing fail, but
> >>> iirc,
> >>> > I think that if the '@lends' directive is to work, it probably needs
> an
> >>> > empty declaration at the class level, like so, prior to the
> >>> > Object.defineProperties:
> >>> >
> >>> >
> >>> > /**
> >>> >  * @protected
> >>> >  * @nocollapse
> >>> >  * @type {Array.<string>}
> >>> >  */
> >>> > flexUnitTests.language.LanguageTesterTestVector.getterTest ;
> >>> >
> >>> > But I have not kept up with the other changes you made, so perhaps
> you
> >>> are
> >>> > trying to avoid these things.... and do some on-the-fly changes
> during
> >>> the
> >>> > GCC pass.
> >>> > Hopefully you might have a quick insight into the issue here
> (protected
> >>> > static getter being accessed in same class in this case)
> >>> >
> >>> >
> >>> >
> >>> > On Thu, Jul 30, 2020 at 6:39 PM Carlos Rovira <
> carlosrovira@apache.org
> >>> >
> >>> > wrote:
> >>> >
> >>> > > Hi,
> >>> > >
> >>> > > doing my daily build and it failed on BindingJS Tests. Just want to
> >>> > report
> >>> > > if it wasn't noticed.
> >>> > > thanks
> >>> > >
> >>> > >
> >>> > > [royaleunit] Suite: flexUnitTests.binding.BindableCoreTests
> >>> > >
> >>> > > [royaleunit] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time
> >>> > > elapsed: 0,984 sec
> >>> > >
> >>> > > [royaleunit] Suite: flexUnitTests.binding.BindingCoreTests
> >>> > >
> >>> > > [royaleunit] Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time
> >>> > > elapsed: 0,615 sec
> >>> > >
> >>> > > [royaleunit]
> >>> > >
> >>> > > [royaleunit] Results :
> >>> > >
> >>> > > [royaleunit]
> >>> > >
> >>> > > [royaleunit] Tests run: 13, Failures: 1, Errors: 0, Skipped: 0,
> Time
> >>> > > elapsed: 1,599 sec
> >>> > >
> >>> > > [royaleunit]
> >>> > >
> >>> > > [junitreport] Processing
> >>> > >
> >>> > >
> >>> >
> >>>
> /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/js/projects/BindingJS/src/test/royale/out/TESTS-TestSuites.xml
> >>> > > to /var/folders/3b/t3splkm10078z3sftzn3_rbr0000gn/T/null1799075660
> >>> > >
> >>> > > [junitreport] Loading stylesheet
> >>> > >
> >>> > >
> >>> >
> >>>
> jar:file:/usr/local/Cellar/ant/1.10.8_1/libexec/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
> >>> > >
> >>> > > [junitreport] Transform time: 40ms
> >>> > >
> >>> > > [junitreport] Deleting:
> >>> > > /var/folders/3b/t3splkm10078z3sftzn3_rbr0000gn/T/null1799075660
> >>> > >
> >>> > >
> >>> > > BUILD FAILED
> >>> > >
> >>> > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/build.xml:667:
> The
> >>> > > following error occurred while executing this line:
> >>> > >
> >>> > >
> >>> >
> >>>
> /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/build.xml:156:
> >>> > > The following error occurred while executing this line:
> >>> > >
> >>> > >
> >>> >
> >>>
> /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/build.xml:283:
> >>> > > The following error occurred while executing this line:
> >>> > >
> >>> > >
> >>> > >
> >>> >
> >>>
> /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/projects/Binding/build.xml:69:
> >>> > > The following error occurred while executing this line:
> >>> > >
> >>> > >
> >>> > >
> >>> >
> >>>
> /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/projects/Binding/build.xml:73:
> >>> > > The following error occurred while executing this line:
> >>> > >
> >>> > >
> >>> > >
> >>> >
> >>>
> /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/js/projects/BindingJS/build.xml:54:
> >>> > > The following error occurred while executing this line:
> >>> > >
> >>> > >
> >>> > >
> >>> >
> >>>
> /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/js/projects/BindingJS/src/test/royale/build.xml:250:
> >>> > > Test Failure
> >>> > >
> >>> > > RoyaleUnit Release Build Tests must pass:
> >>> > >
> >>> > >
> >>> > >
> >>> > >             BindingJS.test RoyaleUnit Release build tests: FAILED
> >>> > >
> >>> > >             BindingJS.test RoyaleUnit Debug build tests: FAILED
> >>> > >
> >>> > >
> >>> > > Total time: 10 minutes 50 seconds
> >>> > >
> >>> > > Error:Build stopped - build SDK with ANT
> >>> > >
> >>> > > --
> >>> > > Carlos Rovira
> >>> > > http://about.me/carlosrovira
> >>> > >
> >>> >
> >>>
> >>>
> >>> --
> >>> Carlos Rovira
> >>> http://about.me/carlosrovira
> >>>
> >>
>


-- 
Carlos Rovira
http://about.me/carlosrovira