You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/01/31 12:40:00 UTC
[jira] [Commented] (PROTON-1998) [Proton-J] Add SASL protocol trace
[ https://issues.apache.org/jira/browse/PROTON-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757192#comment-16757192 ]
ASF GitHub Bot commented on PROTON-1998:
----------------------------------------
k-wall commented on pull request #30: PROTON-1998: Add SASL protocol trace
URL: https://github.com/apache/qpid-proton-j/pull/30
This patch adds a SASL protocol trace that is controlled by the same mechanism as the main protocol trace.
Could you comment on the approach? If it is acceptable, I'll add some tests.
One unsettled question in my mind ProtocolTracer: at the moment, ProtocolTracer implementations don't receive SaslFrameBodies. I did as this would break ProtocolTracer impls (including QpidJMS's - which would ClassCastException). I wondered using a default method ProtocolTracer#ignoreSaslFrameBody which would return true. Comments appreciated..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> [Proton-J] Add SASL protocol trace
> ----------------------------------
>
> Key: PROTON-1998
> URL: https://issues.apache.org/jira/browse/PROTON-1998
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-j
> Reporter: Keith Wall
> Priority: Minor
>
> Unlike Proton, Proton-J does not provide SASL frame trace if environment variable PN_TRACE_FRM is set. It would be useful if Proton-J had this ability too to help diagnose SASL negotiation problem.
> Proton's SASL frame trace looks like this:
> {code:java}
> [0x7fc112c03a00]: -> SASL
> [0x7fc112c03a00]: <- SASL
> [0x7fc112c03a00]:0 <- @sasl-mechanisms(64) [sasl-server-mechanisms=@PN_SYMBOL[:ANONYMOUS]]
> [0x7fc112c03a00]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, initial-response=b"guest@Oslo.local"]
> [0x7fc112c03a00]:0 <- @sasl-outcome(68) [code=0]
> [0x7fc112c03a00]: -> AMQP
> [0x7fc112c03a00]:0 -> @open(16) [container-id="be777c26-af6e-4935-a6be-316cc8bbdb35", hostname="127.0.0.1", channel-max=32767]{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org