[GitHub] [hive] amansinha100 commented on a diff in pull request #4277: HIVE-27305: AssertionError in Calcite during planning for incremental rebuild of materialized view with aggregate on decimal column

["amansinha100 (via GitHub)" <gi...@apache.org>]

amansinha100 commented on code in PR #4277:
URL: https://github.com/apache/hive/pull/4277#discussion_r1182586454


##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveAggregateIncrementalRewritingRuleBase.java:
##########
@@ -142,10 +142,13 @@ public void onMatch(RelOptRuleCall call) {
       // Note: If both are null, we will fall into branch    WHEN leftNull THEN rightRef
       RexNode leftNull = rexBuilder.makeCall(SqlStdOperatorTable.IS_NULL, leftRef);
       RexNode rightNull = rexBuilder.makeCall(SqlStdOperatorTable.IS_NULL, rightRef);
-      projExprs.add(rexBuilder.makeCall(SqlStdOperatorTable.CASE,
+      RexNode caseExpression = rexBuilder.makeCall(SqlStdOperatorTable.CASE,
               leftNull, rightRef,
               rightNull, leftRef,
-              elseReturn));
+              elseReturn);
+      RexNode cast = rexBuilder.makeCast(

Review Comment:
   Ok, so the extra cast gets removed later .. thanks for checking,



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org