You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Alessandro Presta (JIRA)" <ji...@apache.org> on 2012/11/13 19:22:12 UTC

[jira] [Created] (GIRAPH-423) Allow overriding addEdge

Alessandro Presta created GIRAPH-423:
----------------------------------------

             Summary: Allow overriding addEdge
                 Key: GIRAPH-423
                 URL: https://issues.apache.org/jira/browse/GIRAPH-423
             Project: Giraph
          Issue Type: Bug
            Reporter: Alessandro Presta
            Assignee: Alessandro Presta
            Priority: Minor
         Attachments: GIRAPH-423.patch

addEdge() is final in some MutableVertex implementations, whereas other similar methods (like removeEdge()) aren't.
Making it non-final enables some interesting customizations, for example summing the weights of duplicate edges instead of keeping the oldest one.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (GIRAPH-423) Allow overriding addEdge

Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GIRAPH-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alessandro Presta updated GIRAPH-423:
-------------------------------------

    Attachment: GIRAPH-423.patch
    
> Allow overriding addEdge
> ------------------------
>
>                 Key: GIRAPH-423
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-423
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Alessandro Presta
>            Assignee: Alessandro Presta
>            Priority: Minor
>         Attachments: GIRAPH-423.patch
>
>
> addEdge() is final in some MutableVertex implementations, whereas other similar methods (like removeEdge()) aren't.
> Making it non-final enables some interesting customizations, for example summing the weights of duplicate edges instead of keeping the oldest one.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (GIRAPH-423) Allow overriding addEdge

Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496385#comment-13496385 ] 

Alessandro Presta commented on GIRAPH-423:
------------------------------------------

Thanks for the quick review, Maja! Committing...
                
> Allow overriding addEdge
> ------------------------
>
>                 Key: GIRAPH-423
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-423
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Alessandro Presta
>            Assignee: Alessandro Presta
>            Priority: Minor
>         Attachments: GIRAPH-423.patch
>
>
> addEdge() is final in some MutableVertex implementations, whereas other similar methods (like removeEdge()) aren't.
> Making it non-final enables some interesting customizations, for example summing the weights of duplicate edges instead of keeping the oldest one.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (GIRAPH-423) Allow overriding addEdge

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496491#comment-13496491 ] 

Hudson commented on GIRAPH-423:
-------------------------------

Integrated in Giraph-trunk-Commit #281 (See [https://builds.apache.org/job/Giraph-trunk-Commit/281/])
    GIRAPH-423: Allow overriding addEdge (apresta) (Revision 1408870)

     Result = SUCCESS
apresta : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1408870
Files : 
* /giraph/trunk/CHANGELOG
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/EdgeListVertex.java
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/HashMapVertex.java
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/LongDoubleFloatDoubleVertex.java

                
> Allow overriding addEdge
> ------------------------
>
>                 Key: GIRAPH-423
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-423
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Alessandro Presta
>            Assignee: Alessandro Presta
>            Priority: Minor
>         Attachments: GIRAPH-423.patch
>
>
> addEdge() is final in some MutableVertex implementations, whereas other similar methods (like removeEdge()) aren't.
> Making it non-final enables some interesting customizations, for example summing the weights of duplicate edges instead of keeping the oldest one.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (GIRAPH-423) Allow overriding addEdge

Posted by "Maja Kabiljo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496383#comment-13496383 ] 

Maja Kabiljo commented on GIRAPH-423:
-------------------------------------

+1, thanks Alessandro!
                
> Allow overriding addEdge
> ------------------------
>
>                 Key: GIRAPH-423
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-423
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Alessandro Presta
>            Assignee: Alessandro Presta
>            Priority: Minor
>         Attachments: GIRAPH-423.patch
>
>
> addEdge() is final in some MutableVertex implementations, whereas other similar methods (like removeEdge()) aren't.
> Making it non-final enables some interesting customizations, for example summing the weights of duplicate edges instead of keeping the oldest one.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira