You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "xbthink (via GitHub)" <gi...@apache.org> on 2023/09/07 07:03:15 UTC
[GitHub] [incubator-streampark] xbthink opened a new pull request, #3031: fix getService bug
xbthink opened a new pull request, #3031:
URL: https://github.com/apache/incubator-streampark/pull/3031
<!--
Thank you for contributing to StreamPark! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
## Contribution Checklist
- If this is your first time, please read our contributor guidelines: [Submit Code](https://streampark.apache.org/community/submit_guide/submit_code).
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-streampark/issues).
- Name the pull request in the form "[Feature] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- If the PR is unfinished, add `[WIP]` in your PR title, e.g., `[WIP][Feature] Title of the pull request`.
-->
## What changes were proposed in this pull request
Closing k8s flink HA cluster will throw an ApiAlertException("Get shutdown response failed"), because we use directly clusterId as the service name at invoking `FlinkKubernetesClient.getService()`. We need convert clusterId to the service name by adding a suffix `-rest`.
This flink api changed at Flink-26112
<!--(For example: This pull request proposed to add checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verifying this change
<!--*(Please pick either of the following options)*-->
- *Manually verified the change by testing locally.*
## Does this pull request potentially affect one of the following parts
- Dependencies (does it add or upgrade a dependency): (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on pull request #3031: [Bug] fix FlinkKubernetesClient.getService() bug
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #3031:
URL: https://github.com/apache/incubator-streampark/pull/3031#issuecomment-1712699771
Thanks for your contribution. We will review it as soon as possible 😊🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] Al-assad merged pull request #3031: [Bug] fix FlinkKubernetesClient.getService() bug
Posted by "Al-assad (via GitHub)" <gi...@apache.org>.
Al-assad merged PR #3031:
URL: https://github.com/apache/incubator-streampark/pull/3031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] Al-assad commented on pull request #3031: [Bug] fix FlinkKubernetesClient.getService() bug
Posted by "Al-assad (via GitHub)" <gi...@apache.org>.
Al-assad commented on PR #3031:
URL: https://github.com/apache/incubator-streampark/pull/3031#issuecomment-1714869984
> I don't quite understand your question, I double-check the relevant code of other flink-shims and I think we only need to modify the code of streampark-flink-shims_flink-1.16 and streampark-flink-shims_flink-1.17, right? @Al-assad
I made a typo... you're spot on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] xbthink commented on pull request #3031: [Bug] fix FlinkKubernetesClient.getService() bug
Posted by "xbthink (via GitHub)" <gi...@apache.org>.
xbthink commented on PR #3031:
URL: https://github.com/apache/incubator-streampark/pull/3031#issuecomment-1714867141
I don't quite understand your question, I double-check the relevant code of other flink-shims and I think we only need to modify the code of streampark-flink-shims_flink-1.16 and streampark-flink-shims_flink-1.17, right? @Al-assad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] Al-assad commented on pull request #3031: [Bug] fix FlinkKubernetesClient.getService() bug
Posted by "Al-assad (via GitHub)" <gi...@apache.org>.
Al-assad commented on PR #3031:
URL: https://github.com/apache/incubator-streampark/pull/3031#issuecomment-1712701181
> cc @Al-assad If you have time, please review the PR 😉
Okay,I'll be back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on pull request #3031: [Bug] fix FlinkKubernetesClient.getService() bug
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #3031:
URL: https://github.com/apache/incubator-streampark/pull/3031#issuecomment-1712699915
cc @Al-assad If you have time, please review the PR 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org