You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/10/14 08:32:13 UTC
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull
request #3252: purge duplicate method : isDerivedColumnName
terrymanu commented on a change in pull request #3252: purge duplicate method : isDerivedColumnName
URL: https://github.com/apache/incubator-shardingsphere/pull/3252#discussion_r334372026
##########
File path: sharding-core/sharding-core-preprocessor/src/test/java/org/apache/shardingsphere/core/preprocessor/segment/select/projection/DerivedColumnTest.java
##########
@@ -49,15 +49,15 @@ public void assertIsNotDerivedColumn() {
@Test
public void assertIsDerivedColumnName() {
- assertTrue(DerivedColumn.isDerivedColumnName("AVG_DERIVED_COUNT_"));
- assertTrue(DerivedColumn.isDerivedColumnName("AVG_DERIVED_SUM_"));
- assertTrue(DerivedColumn.isDerivedColumnName("ORDER_BY_DERIVED_"));
- assertTrue(DerivedColumn.isDerivedColumnName("GROUP_BY_DERIVED_"));
- assertTrue(DerivedColumn.isDerivedColumnName("AGGREGATION_DISTINCT_DERIVED_"));
+ assertTrue(DerivedColumn.isDerivedColumn("AVG_DERIVED_COUNT_"));
+ assertTrue(DerivedColumn.isDerivedColumn("AVG_DERIVED_SUM_"));
+ assertTrue(DerivedColumn.isDerivedColumn("ORDER_BY_DERIVED_"));
+ assertTrue(DerivedColumn.isDerivedColumn("GROUP_BY_DERIVED_"));
+ assertFalse(DerivedColumn.isDerivedColumn("AGGREGATION_DISTINCT_DERIVED_"));
}
-
+
@Test
public void assertIsNotDerivedColumnName() {
- assertFalse(DerivedColumn.isDerivedColumnName("OTHER_DERIVED_COLUMN_0"));
+ assertFalse(DerivedColumn.isDerivedColumn("OTHER_DERIVED_COLUMN_0"));
Review comment:
Please refactor this test cases to make sure that one method only have one test cases for same scenario.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services