You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "weizhouapache (via GitHub)" <gi...@apache.org> on 2024/04/08 12:11:25 UTC
[PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
weizhouapache opened a new pull request, #8893:
URL: https://github.com/apache/cloudstack/pull/8893
### Description
This PR move upgrade files for 4.19.0->4.20.0 to 4.19.1->4.20.0
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2144505520
@shwstppr what failures are those?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2042589999
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2141237678
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr merged PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2074617598
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2138280118
@shwstppr a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2125496485
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2074475892
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2144572442
ok thanks @shwstppr makes sense. Please note this @sureshanaparti @JoaoJandre , that releasing 4.19.1 before 20 is no longer an option!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2144507858
@DaanHoogland https://github.com/apache/cloudstack/pull/8674#issuecomment-2138150833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2074479161
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud closed pull request #8893: upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0
URL: https://github.com/apache/cloudstack/pull/8893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2144498520
@DaanHoogland you may revert but this is causing test and functional failures. Also, we have added a similar change in the past as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2144435830
great, thanks @shwstppr for the verification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2138149008
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2144481267
I think we should/would wait with merging this untill 4.19.1 is out. in main a reliance on a non existing path is created now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2042758241
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2143727753
@shwstppr a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2144626754
> ok thanks @shwstppr makes sense. Please note this @sureshanaparti @JoaoJandre , that releasing 4.19.1 before 20 is no longer an option!
@DaanHoogland
I think this will not impact 4.19.1 release
I think we have consensus that 4.20 will be released after 4.19.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2144355604
Verified presence of DB changes from 4.19.0 to 4.19.1 and 4.19.1 to 4.20.0 upgrade paths in an env with PR packages,
From 4.19.1 upgrade path:
https://github.com/apache/cloudstack/blob/dc593c543a6bb118d4db5572a1b36e96cf0e34db/engine/schema/src/main/resources/META-INF/db/schema-41900to41910.sql#L35
```
MariaDB [cloud]> describe cloud_usage.usage_networks;
+---------------------+---------------------+------+-----+---------+----------------+
| Field | Type | Null | Key | Default | Extra |
+---------------------+---------------------+------+-----+---------+----------------+
| id | bigint(20) unsigned | NO | PRI | NULL | auto_increment |
| network_offering_id | bigint(20) unsigned | NO | | NULL | |
| zone_id | bigint(20) unsigned | NO | | NULL | |
| network_id | bigint(20) unsigned | NO | | NULL | |
| account_id | bigint(20) unsigned | NO | | NULL | |
| domain_id | bigint(20) unsigned | NO | | NULL | |
| state | varchar(100) | YES | | NULL | |
| removed | datetime | YES | | NULL | |
| created | datetime | NO | | NULL | |
+---------------------+---------------------+------+-----+---------+----------------+
9 rows in set (0.00 sec)
```
`cloud_usage.usage_networks` Table exist
https://github.com/apache/cloudstack/blob/dc593c543a6bb118d4db5572a1b36e96cf0e34db/engine/schema/src/main/resources/META-INF/db/schema-41900to41910.sql#L67
```
MariaDB [cloud]> describe cloud.user_data;
+------------+---------------------+------+-----+---------+----------------+
| Field | Type | Null | Key | Default | Extra |
+------------+---------------------+------+-----+---------+----------------+
| id | bigint(20) unsigned | NO | PRI | NULL | auto_increment |
| uuid | varchar(40) | NO | UNI | NULL | |
| name | varchar(256) | NO | | NULL | |
| account_id | bigint(20) unsigned | NO | MUL | NULL | |
| domain_id | bigint(20) unsigned | NO | MUL | NULL | |
| user_data | mediumtext | YES | | NULL | |
| params | mediumtext | YES | | NULL | |
| removed | datetime | YES | | NULL | |
+------------+---------------------+------+-----+---------+----------------+
8 rows in set (0.00 sec)
```
`removed` column present
From 4.20 upgrade path,
https://github.com/apache/cloudstack/blob/dc593c543a6bb118d4db5572a1b36e96cf0e34db/engine/schema/src/main/resources/META-INF/db/schema-41910to42000.sql#L23
```
MariaDB [cloud]> describe cloud.resource_limit;
+------------+---------------------+------+-----+---------+----------------+
| Field | Type | Null | Key | Default | Extra |
+------------+---------------------+------+-----+---------+----------------+
| id | bigint(20) unsigned | NO | PRI | NULL | auto_increment |
| domain_id | bigint(20) unsigned | YES | MUL | NULL | |
| account_id | bigint(20) unsigned | YES | MUL | NULL | |
| type | varchar(255) | YES | | NULL | |
| max | bigint(20) | NO | | -1 | |
| tag | varchar(64) | YES | | NULL | |
+------------+---------------------+------+-----+---------+----------------+
6 rows in set (0.00 sec)
```
`tag` column present
https://github.com/apache/cloudstack/blob/dc593c543a6bb118d4db5572a1b36e96cf0e34db/engine/schema/src/main/resources/META-INF/db/schema-41910to42000.sql#L84
```
MariaDB [cloud]> describe cloud.host_tags;
+---------------+---------------------+------+-----+---------+----------------+
| Field | Type | Null | Key | Default | Extra |
+---------------+---------------------+------+-----+---------+----------------+
| id | bigint(20) unsigned | NO | PRI | NULL | auto_increment |
| host_id | bigint(20) unsigned | NO | MUL | NULL | |
| tag | text | NO | | NULL | |
| is_tag_a_rule | int(1) unsigned | NO | | 0 | |
| is_implicit | int(1) unsigned | NO | | 0 | |
+---------------+---------------------+------+-----+---------+----------------+
5 rows in set (0.00 sec)
```
`is_implicit` column present
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2140732231
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2139368170
<b>[SF] Trillian test result (tid-10314)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 49964 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8893-t10314-vmware-67u3.zip
Smoke tests completed. 128 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_balanced_drs_algorithm | `Failure` | 134.26 | test_cluster_drs.py
test_02_restore_vm_with_disk_offering | `Error` | 57.18 | test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size | `Error` | 54.10 | test_restore_vm.py
test_02_list_cpvm_vm | `Failure` | 0.05 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.06 | test_ssvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2138202865
> code looks good, but let's wait untill we are sure 4.19.1 is out.
Can we say 4.19.1 will be released before 4.20 now?
:-D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2042991370
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8893?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `50.00000%` with `3 lines` in your changes are missing coverage. Please review.
> Project coverage is 18.81%. Comparing base [(`2959cc6`)](https://app.codecov.io/gh/apache/cloudstack/commit/2959cc67652381e3a39b298e674a0bced5002337?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`9bd4f1e`)](https://app.codecov.io/gh/apache/cloudstack/pull/8893?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 3 commits behind head on main.
| [Files](https://app.codecov.io/gh/apache/cloudstack/pull/8893?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ava/com/cloud/upgrade/dao/Upgrade41910to42000.java](https://app.codecov.io/gh/apache/cloudstack/pull/8893?src=pr&el=tree&filepath=engine%2Fschema%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fupgrade%2Fdao%2FUpgrade41910to42000.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDE5MTB0bzQyMDAwLmphdmE=) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8893?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8893 +/- ##
=============================================
- Coverage 31.20% 18.81% -12.39%
+ Complexity 34146 17064 -17082
=============================================
Files 5410 4879 -531
Lines 380677 326963 -53714
Branches 55578 46200 -9378
=============================================
- Hits 118773 61519 -57254
- Misses 246169 256545 +10376
+ Partials 15735 8899 -6836
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8893/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8893/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `18.81% <50.00%> (-6.17%)` | :arrow_down: |
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8893/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8893/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8893?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2125364730
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2143727621
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2138260332
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2138277857
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2140534625
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2139730293
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2125366503
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2042700925
code looks good, but let's wait untill we are sure 4.19.1 is out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2042586598
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2139233933
<b>[SF] Trillian test result (tid-10313)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45062 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8893-t10313-xenserver-71.zip
Smoke tests completed. 131 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2139516926
<b>[SF] Trillian test result (tid-10315)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 55148 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8893-t10315-kvm-centos7.zip
Smoke tests completed. 129 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_redundant_VPC_default_routes | `Failure` | 382.73 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 405.32 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 521.20 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 521.22 | test_vpc_redundant.py
test_02_VPC_default_routes | `Failure` | 213.88 | test_vpc_router_nics.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2138146972
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2140528665
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2144341055
<b>[SF] Trillian Build Failed (tid-10327)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2144003927
<b>[SF] Trillian test result (tid-10322)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44489 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8893-t10322-kvm-centos7.zip
Smoke tests completed. 132 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2144035158
<b>[SF] Trillian test result (tid-10321)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 51919 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8893-t10321-vmware-67u3.zip
Smoke tests completed. 130 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_balanced_drs_algorithm | `Error` | 426.03 | test_cluster_drs.py
test_02_restore_vm_with_disk_offering | `Error` | 64.46 | test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size | `Error` | 57.19 | test_restore_vm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8893:
URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2144006096
<b>[SF] Trillian test result (tid-10320)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45111 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8893-t10320-xenserver-71.zip
Smoke tests completed. 131 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_trigger_shutdown | `Failure` | 351.65 | test_safe_shutdown.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org