[GitHub] [activemq-artemis] franz1981 commented on pull request #3138: ARTEMIS-2766 Not parsing application properties for duplicate property

[GitBox <gi...@apache.org>]

franz1981 commented on pull request #3138:
URL: https://github.com/apache/activemq-artemis/pull/3138#issuecomment-629589019


   Bud sorry that I have been able to read this just now from my phone: the IdentityHashMap (on MSG_BODY_TYPES) I have used was meant to be used to search just MessageAnnotations: you should remove any (potentially) terminal section before the one you're searching to build the right one for your use case. 
   In the current state of this PR if you hit a MessageAnnotations while searching for Data you will return with a false from the research of the Symbol, that's not correct.
   
   I suggest, for simplicity, to build your own static final Identity hashmap with the correct terminal symbols for the data section (including the data section) and just expose an "anyData" search method instead of a more generic one. Another solution can be to remove the map and use some of the loops used by Robbie or Tim to do similar things, in order to exit when some terminal symbol beyond what you're expecting to find is being found.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org