You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/08/07 20:30:32 UTC
[GitHub] [incubator-pekko-grpc] mdedetrich opened a new pull request, #147: Update references of gradlePluginPortal to mavenCentral()
mdedetrich opened a new pull request, #147:
URL: https://github.com/apache/incubator-pekko-grpc/pull/147
The Gradle plugin now successfully deploys to maven central, see https://github.com/apache/incubator-pekko-grpc/actions/runs/5789438448/job/15690488703. The PR updates the documentation and also updates all references from `gradlePluginPortal`.
Resolves: https://github.com/apache/incubator-pekko-grpc/issues/113.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich merged pull request #147: Update references of gradlePluginPortal to mavenCentral
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #147:
URL: https://github.com/apache/incubator-pekko-grpc/pull/147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on a diff in pull request #147: Update references of gradlePluginPortal to mavenCentral
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #147:
URL: https://github.com/apache/incubator-pekko-grpc/pull/147#discussion_r1286396375
##########
docs/src/main/paradox/buildtools/gradle.md:
##########
@@ -13,25 +13,14 @@ By default, both client and server are generated and Java or Scala is autodetect
### Installation
-**The Gradle plugin is not yet deployed to plugins.gradle.org.**
-
-For now, you will you need to build the plugin yourself and deploy to your local Maven repository.
-Unfortunately, the [Gradle Plugin Publishing](https://docs.gradle.org/current/userguide/publishing_gradle_plugins.html) plugin
-does not appear to support publishing to repositories that require authentication (e.g. Artifactory).
-
-If you check out the source code from our [git repo](https://github.com/apache/incubator-pekko-grpc)
-or [download](https://pekko.apache.org/download.html) a source release, you can change directory to the
-`gradle-plugin` directory and run this Gradle command.
-
-```shell
Review Comment:
Maybe. It's just that it's useful to have a shortened version of the build instructions for release voters. At a minimum, we need to remove the Gradle link in the README because it will become a dead link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on pull request #147: Update references of gradlePluginPortal to mavenCentral
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #147:
URL: https://github.com/apache/incubator-pekko-grpc/pull/147#issuecomment-1668557707
> There is a gradle.md that should be updated (paradox docs). The README links to the section in the gradle.md about the local build - so we should ensure that this link still works - or if we don't think that instructions on how to build the plugin should be in gradle.md, we can move the description to the readme.
I just checked the file and indeed it seems that not even Lightbend/Akka updated it (it mentions that they haven't deployed to Gradle Plugin portal yet). Ill go ahead and update it so its up to scratch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #147: Update references of gradlePluginPortal to mavenCentral
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #147:
URL: https://github.com/apache/incubator-pekko-grpc/pull/147#discussion_r1286394852
##########
docs/src/main/paradox/buildtools/gradle.md:
##########
@@ -13,25 +13,14 @@ By default, both client and server are generated and Java or Scala is autodetect
### Installation
-**The Gradle plugin is not yet deployed to plugins.gradle.org.**
-
-For now, you will you need to build the plugin yourself and deploy to your local Maven repository.
-Unfortunately, the [Gradle Plugin Publishing](https://docs.gradle.org/current/userguide/publishing_gradle_plugins.html) plugin
-does not appear to support publishing to repositories that require authentication (e.g. Artifactory).
-
-If you check out the source code from our [git repo](https://github.com/apache/incubator-pekko-grpc)
-or [download](https://pekko.apache.org/download.html) a source release, you can change directory to the
-`gradle-plugin` directory and run this Gradle command.
-
-```shell
Review Comment:
Wouldn't `CONTRIBUTING.md` be a better spot for these instructions? As a user there really isn't a need to build the project manually, only if you are developing/doing changes to the plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #147: Update references of gradlePluginPortal to mavenCentral
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #147:
URL: https://github.com/apache/incubator-pekko-grpc/pull/147#discussion_r1286406904
##########
.github/workflows/publish-nightly.yml:
##########
@@ -31,7 +31,7 @@ jobs:
NEXUS_USER: ${{ secrets.NEXUS_USER }}
NEXUS_PW: ${{ secrets.NEXUS_PW }}
- - name: Publish Gradle Plugin to Apache Nexus Repository
Review Comment:
This extra info is irrelevant since entire plugin publishes to Apache Nexus repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on pull request #147: Update references of gradlePluginPortal to mavenCentral
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #147:
URL: https://github.com/apache/incubator-pekko-grpc/pull/147#issuecomment-1668555686
There is a gradle.md that should be updated (paradox docs). The README links to the section in the gradle.md about the local build - so we should ensure that this link still works - or if we don't think that instructions on how to build the plugin should be in gradle.md, we can move the description to the readme.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on a diff in pull request #147: Update references of gradlePluginPortal to mavenCentral
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #147:
URL: https://github.com/apache/incubator-pekko-grpc/pull/147#discussion_r1286383577
##########
docs/src/main/paradox/buildtools/gradle.md:
##########
@@ -13,25 +13,14 @@ By default, both client and server are generated and Java or Scala is autodetect
### Installation
-**The Gradle plugin is not yet deployed to plugins.gradle.org.**
-
-For now, you will you need to build the plugin yourself and deploy to your local Maven repository.
-Unfortunately, the [Gradle Plugin Publishing](https://docs.gradle.org/current/userguide/publishing_gradle_plugins.html) plugin
-does not appear to support publishing to repositories that require authentication (e.g. Artifactory).
-
-If you check out the source code from our [git repo](https://github.com/apache/incubator-pekko-grpc)
-or [download](https://pekko.apache.org/download.html) a source release, you can change directory to the
-`gradle-plugin` directory and run this Gradle command.
-
-```shell
Review Comment:
Could you move these local build instructions to the README build from source section if you don't think we could keep them here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on pull request #147: Update references of gradlePluginPortal to mavenCentral
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #147:
URL: https://github.com/apache/incubator-pekko-grpc/pull/147#issuecomment-1668561164
> I added the text about not supporting Gradle Plugin Repository in a previous commit.
No worries, I just updated the text, let me know if its appropriate/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #147: Update references of gradlePluginPortal to mavenCentral
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #147:
URL: https://github.com/apache/incubator-pekko-grpc/pull/147#discussion_r1286407160
##########
docs/src/main/paradox/buildtools/gradle.md:
##########
@@ -13,25 +13,14 @@ By default, both client and server are generated and Java or Scala is autodetect
### Installation
-**The Gradle plugin is not yet deployed to plugins.gradle.org.**
-
-For now, you will you need to build the plugin yourself and deploy to your local Maven repository.
-Unfortunately, the [Gradle Plugin Publishing](https://docs.gradle.org/current/userguide/publishing_gradle_plugins.html) plugin
-does not appear to support publishing to repositories that require authentication (e.g. Artifactory).
-
-If you check out the source code from our [git repo](https://github.com/apache/incubator-pekko-grpc)
-or [download](https://pekko.apache.org/download.html) a source release, you can change directory to the
-`gradle-plugin` directory and run this Gradle command.
-
-```shell
Review Comment:
Okay so I just added info to `README.md` and fixed the link, I think it should be fine now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on pull request #147: Update references of gradlePluginPortal to mavenCentral
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #147:
URL: https://github.com/apache/incubator-pekko-grpc/pull/147#issuecomment-1668559611
> > There is a gradle.md that should be updated (paradox docs). The README links to the section in the gradle.md about the local build - so we should ensure that this link still works - or if we don't think that instructions on how to build the plugin should be in gradle.md, we can move the description to the readme.
>
> I just checked the file and indeed it seems that not even Lightbend/Akka updated it (it mentions that they haven't deployed to Gradle Plugin portal yet). Ill go ahead and update it so its up to scratch.
I added the text about not supporting Gradle Plugin Repository in a previous commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on a diff in pull request #147: Update references of gradlePluginPortal to mavenCentral
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #147:
URL: https://github.com/apache/incubator-pekko-grpc/pull/147#discussion_r1286396375
##########
docs/src/main/paradox/buildtools/gradle.md:
##########
@@ -13,25 +13,14 @@ By default, both client and server are generated and Java or Scala is autodetect
### Installation
-**The Gradle plugin is not yet deployed to plugins.gradle.org.**
-
-For now, you will you need to build the plugin yourself and deploy to your local Maven repository.
-Unfortunately, the [Gradle Plugin Publishing](https://docs.gradle.org/current/userguide/publishing_gradle_plugins.html) plugin
-does not appear to support publishing to repositories that require authentication (e.g. Artifactory).
-
-If you check out the source code from our [git repo](https://github.com/apache/incubator-pekko-grpc)
-or [download](https://pekko.apache.org/download.html) a source release, you can change directory to the
-`gradle-plugin` directory and run this Gradle command.
-
-```shell
Review Comment:
Maybe. It's just that it's useful to have a shortened version of the build instructions for release voters. At a minimum, we need to remove the Gradle link in the README because it will become a deal link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org