You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "thatmikewilliams (via GitHub)" <gi...@apache.org> on 2023/08/27 13:18:19 UTC
[GitHub] [activemq-artemis] thatmikewilliams opened a new pull request, #4593: ARTEMIS-4404 Minor update to the artemis-docker build documentation
thatmikewilliams opened a new pull request, #4593:
URL: https://github.com/apache/activemq-artemis/pull/4593
Clarification of steps required to create a docker image from ActiveMQ source
using the local-distribution method and a couple of formatting recommendations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] thatmaw commented on a diff in pull request #4593: ARTEMIS-4404 Minor update to the artemis-docker build documentation
Posted by "thatmaw (via GitHub)" <gi...@apache.org>.
thatmaw commented on code in PR #4593:
URL: https://github.com/apache/activemq-artemis/pull/4593#discussion_r1309721477
##########
artemis-docker/readme.md:
##########
@@ -134,7 +148,7 @@ From within the `$ARTEMIS_DIST` folder:
$ docker build -f ./docker/Dockerfile-ubuntu-11-jre -t artemis-ubuntu .
```
-# For Ubuntu (Build for linux ARMv7/ARM64)
+## For Ubuntu (Build for linux ARMv7/ARM64)
```
$ docker buildx build --platform linux/arm64,linux/arm/v7 --push -t {your-repository}/apache-artemis:2.17.0-SNAPSHOT -f ./docker/Dockerfile-ubuntu-11 .
Review Comment:
Hi Clebert. Sorry I missed the commit msg req, and thanks Justin for fixing it.
Yes I was able to get a cross platform version of 2.30.0 built. I updated karaf to 4.4.3 as per main which allowed the local build to complete successfully. The other steps worked as written in the doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #4593: ARTEMIS-4404 Minor update to the artemis-docker build documentation
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on PR #4593:
URL: https://github.com/apache/activemq-artemis/pull/4593#issuecomment-1694686591
Can you amend your commit message to include the jira?
git commit --amend
git push origin -f <your-branch_name>
(that should update the commit)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a diff in pull request #4593: ARTEMIS-4404 Minor update to the artemis-docker build documentation
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on code in PR #4593:
URL: https://github.com/apache/activemq-artemis/pull/4593#discussion_r1306677348
##########
artemis-docker/readme.md:
##########
@@ -134,7 +148,7 @@ From within the `$ARTEMIS_DIST` folder:
$ docker build -f ./docker/Dockerfile-ubuntu-11-jre -t artemis-ubuntu .
```
-# For Ubuntu (Build for linux ARMv7/ARM64)
+## For Ubuntu (Build for linux ARMv7/ARM64)
```
$ docker buildx build --platform linux/arm64,linux/arm/v7 --push -t {your-repository}/apache-artemis:2.17.0-SNAPSHOT -f ./docker/Dockerfile-ubuntu-11 .
Review Comment:
Were you able to make this work with 2.30?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #4593: ARTEMIS-4404 Minor update to the artemis-docker build documentation
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #4593:
URL: https://github.com/apache/activemq-artemis/pull/4593#issuecomment-1698003263
Thanks for the contribution @thatmikewilliams!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #4593: ARTEMIS-4404 Minor update to the artemis-docker build documentation
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #4593:
URL: https://github.com/apache/activemq-artemis/pull/4593#issuecomment-1698002957
I fixed this with some git fu.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #4593: ARTEMIS-4404 Minor update to the artemis-docker build documentation
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #4593: ARTEMIS-4404 Minor update to the artemis-docker build documentation
URL: https://github.com/apache/activemq-artemis/pull/4593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org