[GitHub] [drill] agozhiy commented on a change in pull request #2055: DRILL-7693: Updated protobuf version to 3.11.1

[GitBox <gi...@apache.org>]

agozhiy commented on a change in pull request #2055: DRILL-7693: Updated protobuf version to 3.11.1
URL: https://github.com/apache/drill/pull/2055#discussion_r408138273
 
 

 ##########
 File path: common/src/main/java/org/apache/drill/common/util/ProtobufPatcher.java
 ##########
 @@ -57,15 +60,15 @@ public static synchronized void patch() {
   private static void patchByteString() {
     try {
       ClassPool classPool = getClassPool();
-      CtClass byteString = classPool.get("com.google.protobuf.ByteString");
+      CtClass byteString = classPool.get(protobufPackage + "ByteString");
 
 Review comment:
   Verified with different JDBC clients w/ and w/o security, with pam4j and custom auth module, everything is working fine. Also, by decompilation of ProtobufPatcher class from the driver I can see that all strings with package names were renamed with addition of "oadd." prefix.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services