[GitHub] [nifi] exceptionfactory commented on a change in pull request #5899: NIFI-7253 Standardized Jackson dependencies across the codebase.

[GitBox <gi...@apache.org>]

exceptionfactory commented on a change in pull request #5899:
URL: https://github.com/apache/nifi/pull/5899#discussion_r835253267



##########
File path: pom.xml
##########
@@ -551,6 +551,28 @@
                 <scope>import</scope>
                 <type>pom</type>
             </dependency>
+            <dependency>
+                <groupId>com.fasterxml.jackson</groupId>
+                <artifactId>jackson-bom</artifactId>
+                <version>${jackson.version}</version>
+                <type>pom</type>
+                <scope>import</scope>
+            </dependency>
+<!--            <dependency>-->
+<!--                <groupId>com.fasterxml.jackson.core</groupId>-->
+<!--                <artifactId>jackson-databind</artifactId>-->
+<!--                <version>${jackson.version}</version>-->
+<!--            </dependency>-->
+<!--            <dependency>-->
+<!--                <groupId>com.fasterxml.jackson.core</groupId>-->
+<!--                <artifactId>jackson-core</artifactId>-->
+<!--                <version>${jackson.version}</version>-->
+<!--            </dependency>-->
+<!--            <dependency>-->
+<!--                <groupId>com.fasterxml.jackson.core</groupId>-->
+<!--                <artifactId>jackson-annotations</artifactId>-->
+<!--                <version>${jackson.version}</version>-->
+<!--            </dependency>-->

Review comment:
       These commented lines should be removed in the final version.

##########
File path: nifi-commons/nifi-property-protection-factory/pom.xml
##########
@@ -21,6 +21,11 @@
         <version>1.16.0-SNAPSHOT</version>
     </parent>
     <artifactId>nifi-property-protection-factory</artifactId>
+    <properties>
+        <!-- We appear to not be able to use the same version of Jackson here because of a subtle bug related to it
+        in the Azure Identity lib-->
+        <jackson.version>2.12.4</jackson.version>
+    </properties>

Review comment:
       I noticed the following error on the previous build:
   ```
   javax.xml.stream.FactoryConfigurationError: Provider for javax.xml.stream.XMLInputFactory cannot be found
   ```
   
   Can the Azure library be upgraded, instead of hard-coding a particular Jackson version?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org