You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jmeter.apache.org by Philippe Mouawad <ph...@gmail.com> on 2016/03/01 22:59:08 UTC

Re: Switch http.java.sampler.retries to 1

Hi,
Any thoughts on that ?
Thanks

On Sun, Feb 28, 2016 at 9:37 PM, Philippe Mouawad <
philippe.mouawad@gmail.com> wrote:

> Hello,
> To align HttpClient with Java behaviour, I suggest that as for HttpClient,
> we switch this property to 0.
>
>
> Property is by the way not greatly named as a value of 1 means 0 retry.
>
> So maybe we should also fix the algorithm so that 0 means no retry.
>
> int retry = -1;
> for (; retry < MAX_CONN_RETRIES; retry++) {
> --
> Regards.
> Philippe
>



-- 
Cordialement.
Philippe Mouawad.

Re: Switch http.java.sampler.retries to 1

Posted by sebb <se...@gmail.com>.

If we are going to change the default, I guess it does not matter
changing its meaning at the same time, so long as both are clearly
documented.

On 1 March 2016 at 21:59, Philippe Mouawad <ph...@gmail.com> wrote:
> Hi,
> Any thoughts on that ?
> Thanks
>
> On Sun, Feb 28, 2016 at 9:37 PM, Philippe Mouawad <
> philippe.mouawad@gmail.com> wrote:
>
>> Hello,
>> To align HttpClient with Java behaviour, I suggest that as for HttpClient,
>> we switch this property to 0.
>>
>>
>> Property is by the way not greatly named as a value of 1 means 0 retry.
>>
>> So maybe we should also fix the algorithm so that 0 means no retry.
>>
>> int retry = -1;
>> for (; retry < MAX_CONN_RETRIES; retry++) {
>> --
>> Regards.
>> Philippe
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.