[GitHub] [kafka] niteshmor edited a comment on pull request #9556: MINOR: Update jetty to 9.4.33

[GitBox <gi...@apache.org>]

niteshmor edited a comment on pull request #9556:
URL: https://github.com/apache/kafka/pull/9556#issuecomment-721898016


   For applying this fix to older branches, this commit can be cherry-picked to 
   `2.7` branch. For branches `2.6` and earlier, `jersey` version also needs to be
   upgraded to `2.31` based on the following note in `2.5` and `2.6` branches
   that are on jetty `9.4.24`: https://github.com/apache/kafka/blob/2.6/gradle/dependencies.gradle#L71
   
   For validating that this change can be backported, I have prepared commits in 
   my own fork for older branches going back till 2.4 and ran the tests locally.
   Note that I only used Java 11 in my local testing. 
   To assist in applying the fix to older branches, these can serve as a reference
   for what the exact change is. Or I can create new pull requests to the older
   branches if that's easier.
   
   - For 2.7, unit/integration tests pass locally. Reference commit: https://github.com/niteshmor/kafka/commit/8b51bd18f4541d1edb7d423a01314f78f1988fe8
   - For 2.6, 2 tests failed locally, but I believe they are unrelated. The failed tests are:
     - `SslAdminIntegrationTest.testCreateTopicsResponseMetadataAndConfig`
     - `ReplicaManagerTest.testFencedErrorCausedByBecomeLeader`
     Reference commit: https://github.com/niteshmor/kafka/commit/a0d3dc0f2e490d04b324ad72c47cd1363cc9dd6c
   - For 2.5, unit/integration tests pass locally. Reference commit: https://github.com/niteshmor/kafka/commit/f8f68c334132dd293d96d5be1a1c3d307896cefa
   - For 2.4, unit/integration tests pass locally. Reference commit: https://github.com/niteshmor/kafka/commit/9c08944c3c793c7733e0971a68dcb580dd4c288f
              


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org