[GitHub] [skywalking] limfriend commented on issue #4545: add error log(log4j, logback) to span log event

[GitBox <gi...@apache.org>]

limfriend commented on issue #4545: add error log(log4j,logback) to span log event 
URL: https://github.com/apache/skywalking/issues/4545#issuecomment-601618840
 
 
   > I don't think there is much different, if you open sampling at the agent side, then the logs still are ignored like the traceid. They are sharing the same context basically.
   It is very easy to find errors in the existing system, and tracing through the error log is a hundred times only successful once when the sampling rate is 1%.
   
   It is easy to find error log in skywalking if we add error log to span event.
   It is  a hundred times only successful once with error traceId when the sampling rate is 1%.
   We only need to care about which tracings are recorded abnormally, rather than looking for which records from all records one by one.
   Just care about the recorded error span, not all the errors in the log, is efficient way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services