You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/22 22:03:06 UTC
[GitHub] [incubator-mxnet] connorgoggins opened a new pull request #17407:
Implemented final two binary ops, added default params for functionality
connorgoggins opened a new pull request #17407: Implemented final two binary ops, added default params for functionality
URL: https://github.com/apache/incubator-mxnet/pull/17407
## Description ##
Added implementation for `reshape_like` and `choose_element_0index` in opperf, as well as supporting variables in `rules/default_params.py`.
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage
- [x] Code is well-documented
- [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [x] M benchmark/opperf/nd_operations/binary_operators.py
- [x] M benchmark/opperf/utils/op_registry_utils.py
- [x] M benchmark/opperf/rules/default_params.py
- [x] M benchmark/opperf/opperf.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] connorgoggins edited a comment on issue #17407:
Implemented final two binary ops, added default params for functionality
Posted by GitBox <gi...@apache.org>.
connorgoggins edited a comment on issue #17407: Implemented final two binary ops, added default params for functionality
URL: https://github.com/apache/incubator-mxnet/pull/17407#issuecomment-578380590
Individual operator test (GPU): https://gist.github.com/connorgoggins/c74272c24c1e627a6db3709c1b17ee1d
Individual operator test (CPU): https://gist.github.com/connorgoggins/5e86b4a5def363eb2d791592296cd607
Group of operator test - all binary ops (GPU): https://gist.github.com/connorgoggins/948e5cb3d13ff53bfd6b4279abe28d4f
Group of operator test - all binary ops (CPU): https://gist.github.com/connorgoggins/0a5fb08543d164fce68e3c5006b0b264
Full OpPerf test (GPU)*: https://gist.github.com/connorgoggins/cceb63a3d2d17e36a7f26ed7c0c75505
Full OpPerf test (CPU): https://gist.github.com/connorgoggins/1e88cbd6764a74fc2f72b4eb5b7f022a
*Note: couldn't run sorting/searching ops tests in the full test on GPU because they exceeded the device memory of my `p2.8xl` instance. Will do another run on a p2.16xl to get those results.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] access2rohit commented on issue #17407:
Implemented final two binary ops, added default params for functionality
Posted by GitBox <gi...@apache.org>.
access2rohit commented on issue #17407: Implemented final two binary ops, added default params for functionality
URL: https://github.com/apache/incubator-mxnet/pull/17407#issuecomment-578265692
@mxnet-label-bot add [pr-awaiting-merge]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] apeforest merged pull request #17407: Implemented
final two binary ops, added default params for functionality
Posted by GitBox <gi...@apache.org>.
apeforest merged pull request #17407: Implemented final two binary ops, added default params for functionality
URL: https://github.com/apache/incubator-mxnet/pull/17407
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] access2rohit edited a comment on issue #17407:
Implemented final two binary ops, added default params for functionality
Posted by GitBox <gi...@apache.org>.
access2rohit edited a comment on issue #17407: Implemented final two binary ops, added default params for functionality
URL: https://github.com/apache/incubator-mxnet/pull/17407#issuecomment-578265692
@mxnet-label-bot update [pr-awaiting-review]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17407:
Implemented final two binary ops, added default params for functionality
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17407: Implemented final two binary ops, added default params for functionality
URL: https://github.com/apache/incubator-mxnet/pull/17407#issuecomment-577971083
Also you could run the opperf utility by specifying the file format and name of the file
That is the results file I am referring to. Not the stdoutput.
Results file will spit out forward/backward time, memory consumption etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] connorgoggins commented on issue #17407:
Implemented final two binary ops, added default params for functionality
Posted by GitBox <gi...@apache.org>.
connorgoggins commented on issue #17407: Implemented final two binary ops, added default params for functionality
URL: https://github.com/apache/incubator-mxnet/pull/17407#issuecomment-578380590
Individual operator test (GPU): https://gist.github.com/connorgoggins/c74272c24c1e627a6db3709c1b17ee1d
Individual operator test (CPU): https://gist.github.com/connorgoggins/5e86b4a5def363eb2d791592296cd607
Group of operator test - all binary ops (GPU): https://gist.github.com/connorgoggins/948e5cb3d13ff53bfd6b4279abe28d4f
Group of operator test - all binary ops (CPU): https://gist.github.com/connorgoggins/0a5fb08543d164fce68e3c5006b0b264
Full OpPerf test (GPU)*: https://gist.github.com/connorgoggins/cceb63a3d2d17e36a7f26ed7c0c75505
Full OpPerf test (CPU): https://gist.github.com/connorgoggins/1e88cbd6764a74fc2f72b4eb5b7f022a
*Note: couldn't run sorting/searching ops tests in the full test on GPU because they exceeded the device memory. Will do another run on a p2.16xl to get those results. Also, I tested each of the sorting/searching ops individually and they worked properly in both CPU and GPU environments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17407:
Implemented final two binary ops, added default params for functionality
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17407: Implemented final two binary ops, added default params for functionality
URL: https://github.com/apache/incubator-mxnet/pull/17407#issuecomment-578367296
Also it would make sense to add results for
1. Individual operator test (of the 2 added ops)
2. Group of operator test (binary_op in this case)
3. Full OpPerf test (as mentioned in my previous comment)
Just to ensure it is fool-proof.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request
#17407: Implemented final two binary ops,
added default params for functionality
Posted by GitBox <gi...@apache.org>.
apeforest commented on a change in pull request #17407: Implemented final two binary ops, added default params for functionality
URL: https://github.com/apache/incubator-mxnet/pull/17407#discussion_r371600395
##########
File path: benchmark/opperf/utils/op_registry_utils.py
##########
@@ -196,6 +196,28 @@ def get_all_broadcast_binary_operators():
return binary_broadcast_mx_operators
+def get_all_misc_binary_operators():
+ """Gets all miscellaneous binary operators registered with MXNet.
+
+ Returns
+ -------
+ {"operator_name": {"has_backward", "nd_op_handle", "params"}}
+ """
+ # Get all mxnet operators
+ mx_operators = _get_all_mxnet_operators()
+
+ # Filter for miscellaneous binary operators
+ binary_misc_mx_operators = {}
+ for op_name, op_params in mx_operators.items():
+ if "choose_element_0index" == op_name:
+ binary_misc_mx_operators[op_name] = mx_operators[op_name]
+ elif "reshape_like" == op_name:
+ binary_misc_mx_operators[op_name] = mx_operators[op_name]
+ elif "ElementWiseSum" == op_name:
Review comment:
Why is this op not belonging to the `binary_element_wise_operators`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] connorgoggins commented on a change in pull
request #17407: Implemented final two binary ops,
added default params for functionality
Posted by GitBox <gi...@apache.org>.
connorgoggins commented on a change in pull request #17407: Implemented final two binary ops, added default params for functionality
URL: https://github.com/apache/incubator-mxnet/pull/17407#discussion_r369862344
##########
File path: benchmark/opperf/utils/op_registry_utils.py
##########
@@ -196,6 +196,30 @@ def get_all_broadcast_binary_operators():
return binary_broadcast_mx_operators
+def get_all_misc_binary_operators():
+ """Gets all miscellaneous binary operators registered with MXNet.
+
+ Returns
+ -------
+ {"operator_name": {"has_backward", "nd_op_handle", "params"}}
+ """
+ # Get all mxnet operators
+ mx_operators = _get_all_mxnet_operators()
+
+ # Filter for miscellaneous binary operators
+ binary_misc_mx_operators = {}
+ for op_name, op_params in mx_operators.items():
+ if "choose_element_0index" == op_name and op_params["params"]["narg"] == 5 and \
Review comment:
Good point - removing extraneous checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] connorgoggins commented on a change in pull
request #17407: Implemented final two binary ops,
added default params for functionality
Posted by GitBox <gi...@apache.org>.
connorgoggins commented on a change in pull request #17407: Implemented final two binary ops, added default params for functionality
URL: https://github.com/apache/incubator-mxnet/pull/17407#discussion_r371388285
##########
File path: benchmark/opperf/nd_operations/binary_operators.py
##########
@@ -35,7 +35,34 @@
from benchmark.opperf.utils.benchmark_utils import run_op_benchmarks
from benchmark.opperf.utils.op_registry_utils import get_all_broadcast_binary_operators, \
- get_all_elemen_wise_binary_operators
+ get_all_elemen_wise_binary_operators, get_all_misc_binary_operators
+
+
+def run_mx_binary_misc_operators_benchmarks(ctx=mx.cpu(), dtype='float32', profiler='native', warmup=25, runs=100):
Review comment:
For now, just the two additional ops I implemented (`choose_element_0index` and `reshape_like`), since they did not appear to fall into the broadcast or elementwise binary ops categories.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17407:
Implemented final two binary ops, added default params for functionality
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17407: Implemented final two binary ops, added default params for functionality
URL: https://github.com/apache/incubator-mxnet/pull/17407#issuecomment-577556345
Please add results seen on CPU/GPU for reference.
Did you run opperf for all operators after this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request
#17407: Implemented final two binary ops,
added default params for functionality
Posted by GitBox <gi...@apache.org>.
apeforest commented on a change in pull request #17407: Implemented final two binary ops, added default params for functionality
URL: https://github.com/apache/incubator-mxnet/pull/17407#discussion_r370957289
##########
File path: benchmark/opperf/nd_operations/binary_operators.py
##########
@@ -35,7 +35,34 @@
from benchmark.opperf.utils.benchmark_utils import run_op_benchmarks
from benchmark.opperf.utils.op_registry_utils import get_all_broadcast_binary_operators, \
- get_all_elemen_wise_binary_operators
+ get_all_elemen_wise_binary_operators, get_all_misc_binary_operators
+
+
+def run_mx_binary_misc_operators_benchmarks(ctx=mx.cpu(), dtype='float32', profiler='native', warmup=25, runs=100):
Review comment:
Just curious what falls into the *misc* operator category? Could you provide more info
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] access2rohit edited a comment on issue #17407:
Implemented final two binary ops, added default params for functionality
Posted by GitBox <gi...@apache.org>.
access2rohit edited a comment on issue #17407: Implemented final two binary ops, added default params for functionality
URL: https://github.com/apache/incubator-mxnet/pull/17407#issuecomment-578265692
@mxnet-label-bot add [pr-awaiting-review]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya edited a comment on issue #17407:
Implemented final two binary ops, added default params for functionality
Posted by GitBox <gi...@apache.org>.
ChaiBapchya edited a comment on issue #17407: Implemented final two binary ops, added default params for functionality
URL: https://github.com/apache/incubator-mxnet/pull/17407#issuecomment-581716630
Incorrect way to rebase @connorgoggins
First get your master branch updated
```
git remote add upstream https://github.com/apache/incubator-mxnet
git checkout master
git fetch upstream master
git merge upstream/master
git push origin master
```
Once your fork master is sync'ed with remote master, rebase your branch on master
```
git checkout <branchname>
git rebase master
git push origin <branchname>
```
Let me know if this works!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] connorgoggins edited a comment on issue #17407:
Implemented final two binary ops, added default params for functionality
Posted by GitBox <gi...@apache.org>.
connorgoggins edited a comment on issue #17407: Implemented final two binary ops, added default params for functionality
URL: https://github.com/apache/incubator-mxnet/pull/17407#issuecomment-578380590
Individual operator test (GPU): https://gist.github.com/connorgoggins/c74272c24c1e627a6db3709c1b17ee1d
Individual operator test (CPU): https://gist.github.com/connorgoggins/5e86b4a5def363eb2d791592296cd607
Group of operator test - all binary ops (GPU): https://gist.github.com/connorgoggins/948e5cb3d13ff53bfd6b4279abe28d4f
Group of operator test - all binary ops (CPU): https://gist.github.com/connorgoggins/0a5fb08543d164fce68e3c5006b0b264
Full OpPerf test (GPU)*: https://gist.github.com/connorgoggins/cceb63a3d2d17e36a7f26ed7c0c75505
Full OpPerf test (CPU): https://gist.github.com/connorgoggins/1e88cbd6764a74fc2f72b4eb5b7f022a
*Note: couldn't run sorting/searching ops tests in the full test on GPU because they exceeded the device memory of my `p2.8xl` instance. Will do another run on a p2.16xl to get those results, but regardless my implementation of these two binary operators has no bearing on the logic of sorting/searching ops.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] connorgoggins commented on a change in pull
request #17407: Implemented final two binary ops,
added default params for functionality
Posted by GitBox <gi...@apache.org>.
connorgoggins commented on a change in pull request #17407: Implemented final two binary ops, added default params for functionality
URL: https://github.com/apache/incubator-mxnet/pull/17407#discussion_r372704881
##########
File path: benchmark/opperf/utils/op_registry_utils.py
##########
@@ -196,6 +196,28 @@ def get_all_broadcast_binary_operators():
return binary_broadcast_mx_operators
+def get_all_misc_binary_operators():
+ """Gets all miscellaneous binary operators registered with MXNet.
+
+ Returns
+ -------
+ {"operator_name": {"has_backward", "nd_op_handle", "params"}}
+ """
+ # Get all mxnet operators
+ mx_operators = _get_all_mxnet_operators()
+
+ # Filter for miscellaneous binary operators
+ binary_misc_mx_operators = {}
+ for op_name, op_params in mx_operators.items():
+ if "choose_element_0index" == op_name:
+ binary_misc_mx_operators[op_name] = mx_operators[op_name]
+ elif "reshape_like" == op_name:
+ binary_misc_mx_operators[op_name] = mx_operators[op_name]
+ elif "ElementWiseSum" == op_name:
Review comment:
Good point @apeforest, changing now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] connorgoggins commented on issue #17407:
Implemented final two binary ops, added default params for functionality
Posted by GitBox <gi...@apache.org>.
connorgoggins commented on issue #17407: Implemented final two binary ops, added default params for functionality
URL: https://github.com/apache/incubator-mxnet/pull/17407#issuecomment-577811150
@ChaiBapchya https://gist.github.com/connorgoggins/294f55595311c3b811662af08a787f2a
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] connorgoggins edited a comment on issue #17407:
Implemented final two binary ops, added default params for functionality
Posted by GitBox <gi...@apache.org>.
connorgoggins edited a comment on issue #17407: Implemented final two binary ops, added default params for functionality
URL: https://github.com/apache/incubator-mxnet/pull/17407#issuecomment-578380590
Individual operator test (GPU): https://gist.github.com/connorgoggins/c74272c24c1e627a6db3709c1b17ee1d
Individual operator test (CPU): https://gist.github.com/connorgoggins/5e86b4a5def363eb2d791592296cd607
Group of operator test - all binary ops (GPU): https://gist.github.com/connorgoggins/948e5cb3d13ff53bfd6b4279abe28d4f
Group of operator test - all binary ops (CPU): https://gist.github.com/connorgoggins/0a5fb08543d164fce68e3c5006b0b264
Full OpPerf test (GPU)*: https://gist.github.com/connorgoggins/cceb63a3d2d17e36a7f26ed7c0c75505
Full OpPerf test (CPU): https://gist.github.com/connorgoggins/1e88cbd6764a74fc2f72b4eb5b7f022a
*Note: couldn't run sorting/searching ops tests in the full test on GPU because they exceeded the device memory of my `p2.8xl` instance. Will do another run on a p2.16xl to get those results, but regardless these two binary operators have no bearing on the logic of sorting/searching ops.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17407:
Implemented final two binary ops, added default params for functionality
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17407: Implemented final two binary ops, added default params for functionality
URL: https://github.com/apache/incubator-mxnet/pull/17407#issuecomment-577556427
A gist link with the results would do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17407:
Implemented final two binary ops, added default params for functionality
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17407: Implemented final two binary ops, added default params for functionality
URL: https://github.com/apache/incubator-mxnet/pull/17407#issuecomment-578952083
Let's add ElementwiseSum op too
https://mxnet.incubator.apache.org/api/python/docs/api/ndarray/ndarray.html#mxnet.ndarray.ElementWiseSum
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] connorgoggins commented on issue #17407:
Implemented final two binary ops, added default params for functionality
Posted by GitBox <gi...@apache.org>.
connorgoggins commented on issue #17407: Implemented final two binary ops, added default params for functionality
URL: https://github.com/apache/incubator-mxnet/pull/17407#issuecomment-580038614
Full OpPerf test (CPU): https://gist.github.com/connorgoggins/d39b9adc63c3efabe81cfac34c5dfe1a
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17407:
Implemented final two binary ops, added default params for functionality
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17407: Implemented final two binary ops, added default params for functionality
URL: https://github.com/apache/incubator-mxnet/pull/17407#issuecomment-580451007
Not in this PR but in one of the other 3 PRs that you have open you can add yourself to the Contributors.md file
Welcome to the group!! @connorgoggins
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request
#17407: Implemented final two binary ops,
added default params for functionality
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on a change in pull request #17407: Implemented final two binary ops, added default params for functionality
URL: https://github.com/apache/incubator-mxnet/pull/17407#discussion_r369844769
##########
File path: benchmark/opperf/utils/op_registry_utils.py
##########
@@ -196,6 +196,30 @@ def get_all_broadcast_binary_operators():
return binary_broadcast_mx_operators
+def get_all_misc_binary_operators():
+ """Gets all miscellaneous binary operators registered with MXNet.
+
+ Returns
+ -------
+ {"operator_name": {"has_backward", "nd_op_handle", "params"}}
+ """
+ # Get all mxnet operators
+ mx_operators = _get_all_mxnet_operators()
+
+ # Filter for miscellaneous binary operators
+ binary_misc_mx_operators = {}
+ for op_name, op_params in mx_operators.items():
+ if "choose_element_0index" == op_name and op_params["params"]["narg"] == 5 and \
Review comment:
why do we need to check for other params?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17407:
Implemented final two binary ops, added default params for functionality
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17407: Implemented final two binary ops, added default params for functionality
URL: https://github.com/apache/incubator-mxnet/pull/17407#issuecomment-581716630
Incorrect way to rebase
First get your master branch updated
```
git remote add upstream https://github.com/apache/incubator-mxnet
git checkout master
git fetch upstream master
git merge upstream/master
git push origin master
```
Once your fork master is sync'ed with remote master, rebase your branch on master
```
git checkout <branchname>
git rebase master
git push origin <branchname>
```
Let me know if this works!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services