You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by "bjornjorgensen (via GitHub)" <gi...@apache.org> on 2023/02/25 14:18:33 UTC
[GitHub] [spark-website] bjornjorgensen opened a new pull request, #442: Remove Jenkins from dev-tools page
bjornjorgensen opened a new pull request, #442:
URL: https://github.com/apache/spark-website/pull/442
<!-- *Make sure that you generate site HTML with `bundle exec jekyll build`, and include the changes to the HTML in your pull request. See README.md for more information.* -->
`bundle exec jekyll build --watch`
Removed info about Jerkins from the .md fil
Regenerating: 1 file(s) changed at 2023-02-25 15:14:42
developer-tools.md
...done in 2.778396909 seconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] bjornjorgensen commented on pull request #442: Remove Jenkins from dev-tools page
Posted by "bjornjorgensen (via GitHub)" <gi...@apache.org>.
bjornjorgensen commented on PR #442:
URL: https://github.com/apache/spark-website/pull/442#issuecomment-1445138689
And in https://spark.apache.org/release-process.html
"It is also good to set up Jenkins jobs for the release branch once it is cut to ensure tests are passing. These are jobs like https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test/job/spark-branch-2.3-test-maven-hadoop-2.7/ . Consult Josh Rosen and Shane Knapp for help with this. Also remember to add the newly-added jobs to the test dashboard at https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/ ."
"Also check that all build and test passes are green from the RISELab Jenkins: https://amplab.cs.berkeley.edu/jenkins/ particularly look for Spark Packaging, QA Compile, QA Test. Note that not all permutations are run on PR therefore it is important to check Jenkins runs."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] bjornjorgensen commented on pull request #442: Remove Jenkins from dev-tools page
Posted by "bjornjorgensen (via GitHub)" <gi...@apache.org>.
bjornjorgensen commented on PR #442:
URL: https://github.com/apache/spark-website/pull/442#issuecomment-1445139213
and in https://spark.apache.org/contributing.html
"The Jenkins automatic pull request builder will test your changes
If it is your first contribution, Jenkins will wait for confirmation before building your code and post “Can one of the admins verify this patch?”
A committer can authorize testing with a comment like “ok to test”
A committer can automatically allow future pull requests from a contributor to be tested with a comment like “Jenkins, add to whitelist”
After about 2 hours, Jenkins will post the results of the test to the pull request, along with a link to the full results on Jenkins.
Watch for the results, and investigate and fix failures promptly
Fixes can simply be pushed to the same branch from which you opened your pull request
Jenkins will automatically re-test when new commits are pushed
If the tests failed for reasons unrelated to the change (e.g. Jenkins outage), then a committer can request a re-test with “Jenkins, retest this please”. Ask if you need a test restarted. If you were added by “Jenkins, add to whitelist” from a committer before, you can also request the re-test."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] bjornjorgensen commented on pull request #442: Remove Jenkins from dev-tools page
Posted by "bjornjorgensen (via GitHub)" <gi...@apache.org>.
bjornjorgensen commented on PR #442:
URL: https://github.com/apache/spark-website/pull/442#issuecomment-1445165797
Now there are something about running jenkins test on github enterprise that are left I hope. https://spark.apache.org/docs/latest/building-spark.html#running-jenkins-tests-with-github-enterprise
Where should I remove this one then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] bjornjorgensen commented on pull request #442: Remove Jenkins from dev-tools page
Posted by "bjornjorgensen (via GitHub)" <gi...@apache.org>.
bjornjorgensen commented on PR #442:
URL: https://github.com/apache/spark-website/pull/442#issuecomment-1445138227
hmm.. there is one more
"If you open a pull request containing binary incompatibilities anyway, Jenkins will remind you by failing the test build with the following message:
Test build #xx has finished for PR yy at commit ffffff.
This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes."
should I remove this one to?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] bjornjorgensen commented on a diff in pull request #442: Remove Jenkins from dev-tools page
Posted by "bjornjorgensen (via GitHub)" <gi...@apache.org>.
bjornjorgensen commented on code in PR #442:
URL: https://github.com/apache/spark-website/pull/442#discussion_r1117954171
##########
developer-tools.md:
##########
@@ -274,17 +262,6 @@ A binary incompatibility reported by MiMa might look like the following:
[error] filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.SomeClass.this")
```
-If you open a pull request containing binary incompatibilities anyway, Jenkins
Review Comment:
What does Github actions do her?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] bjornjorgensen commented on pull request #442: Remove Jenkins from pages
Posted by "bjornjorgensen (via GitHub)" <gi...@apache.org>.
bjornjorgensen commented on PR #442:
URL: https://github.com/apache/spark-website/pull/442#issuecomment-1445179651
@dongjoon-hyun FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] srowen closed pull request #442: Remove Jenkins from pages
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen closed pull request #442: Remove Jenkins from pages
URL: https://github.com/apache/spark-website/pull/442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] bjornjorgensen commented on a diff in pull request #442: Remove Jenkins from dev-tools page
Posted by "bjornjorgensen (via GitHub)" <gi...@apache.org>.
bjornjorgensen commented on code in PR #442:
URL: https://github.com/apache/spark-website/pull/442#discussion_r1117954019
##########
contributing.md:
##########
@@ -387,21 +387,6 @@ will trigger workflows "On pull request*" (on Spark repo) that will look/watch f
1. The related JIRA, if any, will be marked as "In Progress" and your pull request will
automatically be linked to it. There is no need to be the Assignee of the JIRA to work on it,
though you are welcome to comment that you have begun work.
-1. The Jenkins automatic pull request builder will test your changes
Review Comment:
Here we can write about enable github actions on fork. And that github actions are running test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] srowen commented on a diff in pull request #442: Remove Jenkins from pages
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on code in PR #442:
URL: https://github.com/apache/spark-website/pull/442#discussion_r1117956071
##########
developer-tools.md:
##########
@@ -274,17 +262,6 @@ A binary incompatibility reported by MiMa might look like the following:
[error] filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.SomeClass.this")
```
-If you open a pull request containing binary incompatibilities anyway, Jenkins
Review Comment:
I would just remove these references, all of the Jenkins references. I think it's OK, rather than rewriting them in terms of GHA. We can add back docs later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org