You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@twopensource.com> on 2014/09/05 01:16:26 UTC
Review Request 25366: Set principal field in FrameworkInfo struct.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25366/
-----------------------------------------------------------
Review request for Aurora, Joshua Cohen, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
Bugs: AURORA-687
https://issues.apache.org/jira/browse/AURORA-687
Repository: aurora
Description
-------
Set principal field in FrameworkInfo struct.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/DriverFactory.java 9cc04a84a37374ffca418e2ff767992ee23b9f3e
Diff: https://reviews.apache.org/r/25366/diff/
Testing
-------
./gradlew build -Pq
Thanks,
Zameer Manji
Re: Review Request 25366: Set principal field in FrameworkInfo struct.
Posted by Joshua Cohen <jc...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25366/#review52371
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/DriverFactory.java
<https://reviews.apache.org/r/25366/#comment91136>
properties.getProperty() rather than properties.get(...).toString()
Also, given that we're getting this multiple times (above for the log, below for the Credential), might make sense to just get it once and reuse (though the above is just a get call, not sure if there's any downside there to the implicit string conversion done by getProperty).
- Joshua Cohen
On Sept. 4, 2014, 11:16 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25366/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2014, 11:16 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
>
>
> Bugs: AURORA-687
> https://issues.apache.org/jira/browse/AURORA-687
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Set principal field in FrameworkInfo struct.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/DriverFactory.java 9cc04a84a37374ffca418e2ff767992ee23b9f3e
>
> Diff: https://reviews.apache.org/r/25366/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 25366: Set principal field in FrameworkInfo struct.
Posted by Joshua Cohen <jc...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25366/#review52377
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On Sept. 4, 2014, 11:36 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25366/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2014, 11:36 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
>
>
> Bugs: AURORA-687
> https://issues.apache.org/jira/browse/AURORA-687
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Set principal field in FrameworkInfo struct.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/DriverFactory.java 9cc04a84a37374ffca418e2ff767992ee23b9f3e
>
> Diff: https://reviews.apache.org/r/25366/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 25366: Set principal field in FrameworkInfo struct.
Posted by Kevin Sweeney <ke...@apache.org>.
> On Sept. 5, 2014, 8:05 a.m., Bill Farner wrote:
> > Can you enable framework authentication in the vagrant environment to exercise this code?
+1
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25366/#review52454
-----------------------------------------------------------
On Sept. 4, 2014, 4:36 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25366/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2014, 4:36 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
>
>
> Bugs: AURORA-687
> https://issues.apache.org/jira/browse/AURORA-687
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Set principal field in FrameworkInfo struct.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/DriverFactory.java 9cc04a84a37374ffca418e2ff767992ee23b9f3e
>
> Diff: https://reviews.apache.org/r/25366/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 25366: Set principal field in FrameworkInfo struct.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25366/#review52454
-----------------------------------------------------------
Can you enable framework authentication in the vagrant environment to exercise this code?
- Bill Farner
On Sept. 4, 2014, 11:36 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25366/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2014, 11:36 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
>
>
> Bugs: AURORA-687
> https://issues.apache.org/jira/browse/AURORA-687
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Set principal field in FrameworkInfo struct.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/DriverFactory.java 9cc04a84a37374ffca418e2ff767992ee23b9f3e
>
> Diff: https://reviews.apache.org/r/25366/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 25366: Set principal field in FrameworkInfo struct.
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25366/
-----------------------------------------------------------
(Updated Sept. 4, 2014, 4:36 p.m.)
Review request for Aurora, Joshua Cohen, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
Changes
-------
Use .getProperty
Bugs: AURORA-687
https://issues.apache.org/jira/browse/AURORA-687
Repository: aurora
Description
-------
Set principal field in FrameworkInfo struct.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/DriverFactory.java 9cc04a84a37374ffca418e2ff767992ee23b9f3e
Diff: https://reviews.apache.org/r/25366/diff/
Testing
-------
./gradlew build -Pq
Thanks,
Zameer Manji