You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/09/23 14:04:15 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5548: Remove the oal incorrect example

wu-sheng commented on a change in pull request #5548:
URL: https://github.com/apache/skywalking/pull/5548#discussion_r493619628



##########
File path: docs/en/concepts-and-designs/oal.md
##########
@@ -120,12 +120,6 @@ endpoint_percentile = from(Endpoint.latency).percentile(10)
 // Caculate the percent of response status is true, for each service.
 endpoint_success = from(Endpoint.*).filter(status == true).percent()
 
-// Caculate the percent of response code in [200, 299], for each service.
-endpoint_200 = from(Endpoint.*).filter(responseCode like "2%").percent()
-
-// Caculate the percent of response code in [500, 599], for each service.
-endpoint_500 = from(Endpoint.*).filter(responseCode like "5%").percent()
-

Review comment:
       I think we still should have some `like` examples, such as, `name like "namespace1.%"`? Uses may need to filter the services for the specific metrics. WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org