You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/06/14 14:43:15 UTC
[GitHub] [incubator-doris] morningman opened a new pull request #3860: [Compaction] Resolve the `-230` error by recording latest read version of a tablet
morningman opened a new pull request #3860:
URL: https://github.com/apache/incubator-doris/pull/3860
Fix #3859
This CL mainly changes:
1. add a new field `_latest_read_version` for tablet on BE to save the largest version which has
been read by query.
2. Modify the cumulative compaction logic. When select rowset to merge, consider both
`cumulative_compaction_skip_window_seconds` and `_latest_read_version`.
3. Add some docs for config
4. Remove unused config `cumulative_compaction_budgeted_bytes`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman closed pull request #3860: [Compaction] Resolve the `-230` error by saving latest read version of a tablet
Posted by GitBox <gi...@apache.org>.
morningman closed pull request #3860:
URL: https://github.com/apache/incubator-doris/pull/3860
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #3860: [Compaction] Resolve the `-230` error by saving latest read version of a tablet
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #3860:
URL: https://github.com/apache/incubator-doris/pull/3860#discussion_r439837920
##########
File path: be/src/olap/tablet.cpp
##########
@@ -852,12 +853,11 @@ TabletInfo Tablet::get_tablet_info() const {
return TabletInfo(tablet_id(), schema_hash(), tablet_uid());
}
-void Tablet::pick_candicate_rowsets_to_cumulative_compaction(int64_t skip_window_sec,
- std::vector<RowsetSharedPtr>* candidate_rowsets) {
- int64_t now = UnixSeconds();
+void Tablet::pick_candicate_rowsets_to_cumulative_compaction(
+ std::vector<RowsetSharedPtr>* candidate_rowsets) {
ReadLock rdlock(&_meta_lock);
for (auto& it : _rs_version_map) {
- if (it.first.first >= _cumulative_point && (it.second->creation_time() + skip_window_sec < now)) {
+ if (it.first.first >= _cumulative_point) {
Review comment:
For reviewer: Remove the `skip_window_sec` check here, it will be checked later in cumulative compaction process.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org