You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@felix.apache.org by GitBox <gi...@apache.org> on 2021/02/17 12:32:03 UTC

[GitHub] [felix-atomos] karlpauls commented on pull request #46: Add a headers provider hook

karlpauls commented on pull request #46:
URL: https://github.com/apache/felix-atomos/pull/46#issuecomment-780525300


   @tjwatson, I fixed a couple of missing framework.waitForStop calls in the tests and additionally some java doc. Furthermore, I changed the apply for the header provider to wrap the result in a new map to make sure headers can't be changed after the fact as well as that we can modify the headers. Ultimately, I introduced a new temporary header to indicate that we want to recalculate the requires. With that, it looks like the tests are passing and I think we have everything - please have another look if you agree with these changes. I think we are good to merge.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org