You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/09/16 17:57:51 UTC

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8231: [SQL Lab] Fix bug when filtering on results that include nulls

codecov-io edited a comment on issue #8231: [SQL Lab] Fix bug when filtering on results that include nulls
URL: https://github.com/apache/incubator-superset/pull/8231#issuecomment-531887731
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8231?src=pr&el=h1) Report
   > Merging [#8231](https://codecov.io/gh/apache/incubator-superset/pull/8231?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/bf7ce62166a753d2e05a0a7d3dcbaff486784dad?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/8231/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8231?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #8231      +/-   ##
   ==========================================
   + Coverage   65.97%   65.98%   +<.01%     
   ==========================================
     Files         479      479              
     Lines       23038    23038              
     Branches     2552     2552              
   ==========================================
   + Hits        15200    15202       +2     
   + Misses       7702     7700       -2     
     Partials      136      136
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8231?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...src/components/FilterableTable/FilterableTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8231/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0ZpbHRlcmFibGVUYWJsZS9GaWx0ZXJhYmxlVGFibGUuanN4) | `79.88% <100%> (+1.14%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8231?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8231?src=pr&el=footer). Last update [bf7ce62...a261308](https://codecov.io/gh/apache/incubator-superset/pull/8231?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org