You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by sv...@apache.org on 2019/05/15 21:24:46 UTC
[wicket] 06/16: WICKET-6667 JS removed Wicket.Browser.isChrome()
This is an automated email from the ASF dual-hosted git repository.
svenmeier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/wicket.git
commit c19f016071869334880f2caba02d3e9e3842013d
Author: Sven Meier <sv...@apache.org>
AuthorDate: Mon May 6 14:50:31 2019 +0200
WICKET-6667 JS removed Wicket.Browser.isChrome()
wasn't used at all
---
.../java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js | 9 ---------
wicket-core/src/test/js/amd.js | 3 +--
2 files changed, 1 insertion(+), 11 deletions(-)
diff --git a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
index c20b86a..6eaf581 100644
--- a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
+++ b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
@@ -2454,15 +2454,6 @@
jQuery.extend(true, Wicket, {
Browser: {
- _isChrome: null,
- isChrome: function () {
- var wb = Wicket.Browser;
- if (wb._isChrome === null) {
- wb._isChrome = (/KHTML/).test(window.navigator.userAgent) && /Apple/.test(window.navigator.userAgent) && /Chrome/.test(window.navigator.userAgent);
- }
- return wb._isChrome;
- },
-
_isIE: null,
isIE: function () {
var wb = Wicket.Browser;
diff --git a/wicket-core/src/test/js/amd.js b/wicket-core/src/test/js/amd.js
index d2617d2..8756d65 100644
--- a/wicket-core/src/test/js/amd.js
+++ b/wicket-core/src/test/js/amd.js
@@ -32,10 +32,9 @@ define(
runTests: function () {
qunit.test("Wicket object is successfully loaded via RequireJs", function () {
- qunit.expect(15);
+ qunit.expect(14);
// test for one member for each Wicket.** module
- qunit.ok($.isFunction(w.Browser.isChrome), "Wicket Browser (from wicket-ajax-jquery.js) is imported");
qunit.ok($.isFunction(w.Event.fix), "Wicket Event (from wicket-ajax-jquery.js) is imported");
qunit.ok($.isFunction(w.Ajax.ajax), "Wicket Ajax (from wicket-ajax-jquery.js) is imported");
qunit.ok($.isFunction(w.DOM.get), "Wicket DOM (from wicket-ajax-jquery.js) is imported");