You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/03/23 15:58:07 UTC
[GitHub] [logging-log4j2] henryw374 opened a new pull request #477: MapMessage put methods should not mandate String values
henryw374 opened a new pull request #477:
URL: https://github.com/apache/logging-log4j2/pull/477
the underlying Map is typed <String,Object> so the put methods on MapMessage can also be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy closed pull request #477: MapMessage put methods should not mandate String values
Posted by GitBox <gi...@apache.org>.
vy closed pull request #477:
URL: https://github.com/apache/logging-log4j2/pull/477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] rgoers commented on pull request #477: MapMessage put methods should not mandate String values
Posted by GitBox <gi...@apache.org>.
rgoers commented on pull request #477:
URL: https://github.com/apache/logging-log4j2/pull/477#issuecomment-974773142
The discussion on the mailing list died off without any clear resolution. I'm not sure what to do with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] rgoers commented on pull request #477: MapMessage put methods should not mandate String values
Posted by GitBox <gi...@apache.org>.
rgoers commented on pull request #477:
URL: https://github.com/apache/logging-log4j2/pull/477#issuecomment-974773142
The discussion on the mailing list died off without any clear resolution. I'm not sure what to do with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy commented on pull request #477: MapMessage put methods should not mandate String values
Posted by GitBox <gi...@apache.org>.
vy commented on pull request #477:
URL: https://github.com/apache/logging-log4j2/pull/477#issuecomment-806455867
@henryw374, I have mentioned about your PR in the dev mailing list, there is [a discussion going on](https://mail-archives.apache.org/mod_mbox/logging-dev/202103.mbox/%3CCAP7pH7sG%2B82UUZK91w2%2BQO%2BaJceZm5zFaCO4UwwKGtdiw_y5Cg%40mail.gmail.com%3E). Long story short, it is not as easy as it seems. I'd suggest you to join the discussion, if you want to get this resolved soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] henryw374 commented on pull request #477: MapMessage put methods should not mandate String values
Posted by GitBox <gi...@apache.org>.
henryw374 commented on pull request #477:
URL: https://github.com/apache/logging-log4j2/pull/477#issuecomment-806502079
Thanks. I'll look in the forum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy commented on pull request #477: MapMessage put methods should not mandate String values
Posted by GitBox <gi...@apache.org>.
vy commented on pull request #477:
URL: https://github.com/apache/logging-log4j2/pull/477#issuecomment-975942442
IIRC, as indicated in the mailing list discussion, the necessary set of changes is not as simple as this PR implies. I am taking the liberty to close this ticket. Feel free to re-open it if you have any objections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] henryw374 commented on pull request #477: MapMessage put methods should not mandate String values
Posted by GitBox <gi...@apache.org>.
henryw374 commented on pull request #477:
URL: https://github.com/apache/logging-log4j2/pull/477#issuecomment-806511345
I've sent a subscribe message to the list now.
To add a bit more info, there is a constructor of MapMessage which takes a single map arg :
```
public MapMessage(final Map<String, V> map) {
this.data = new SortedArrayStringMap(map);
}
```
which I am using already with things like maps of maps etc - which get printed to nested json. So the put* methods are inconsistent with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org