You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by sk...@apache.org on 2013/06/04 00:21:33 UTC
svn commit: r1489208 - in /maven/sandbox/trunk/dist-tools/dist-tool-plugin:
./ src/main/java/org/apache/maven/dist/tools/
src/main/java/org/apache/maven/dist/tools/checkers/ src/site/markdown/
Author: skygo
Date: Mon Jun 3 22:21:33 2013
New Revision: 1489208
URL: http://svn.apache.org/r1489208
Log:
try to detect skin ( display html comment where available)
refactoring
Added:
maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/DistCheckSiteTakeScreenMojo.java
- copied, changed from r1489084, maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/DistCheckSiteMojo.java
Modified:
maven/sandbox/trunk/dist-tools/dist-tool-plugin/pom.xml
maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/AbstractDistCheckMojo.java
maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/DistCheckSiteMojo.java
maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/checkers/FluidoHTMLChecker.java
maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/checkers/HTMLChecker.java
maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/checkers/StylusLeftHTMLChecker.java
maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/checkers/StylusRightHTMLChecker.java
maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/site/markdown/todo.md
Modified: maven/sandbox/trunk/dist-tools/dist-tool-plugin/pom.xml
URL: http://svn.apache.org/viewvc/maven/sandbox/trunk/dist-tools/dist-tool-plugin/pom.xml?rev=1489208&r1=1489207&r2=1489208&view=diff
==============================================================================
--- maven/sandbox/trunk/dist-tools/dist-tool-plugin/pom.xml (original)
+++ maven/sandbox/trunk/dist-tools/dist-tool-plugin/pom.xml Mon Jun 3 22:21:33 2013
@@ -78,6 +78,10 @@
<artifactId>maven-model</artifactId>
<groupId>org.apache.maven</groupId>
</exclusion>
+ <exclusion>
+ <artifactId>xml-apis</artifactId>
+ <groupId>xml-apis</groupId>
+ </exclusion>
</exclusions>
</dependency>
<dependency>
@@ -90,7 +94,11 @@
<artifactId>aether-util</artifactId>
<version>0.9.0.M2</version>
</dependency>
-
+ <dependency>
+ <groupId>xml-apis</groupId>
+ <artifactId>xml-apis</artifactId>
+ <version>1.4.01</version>
+ </dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-aether-provider</artifactId>
@@ -101,6 +109,30 @@
<artifactId>maven-artifact</artifactId>
<version>2.2.0</version>
</dependency>
+ <dependency>
+ <groupId>org.seleniumhq.selenium</groupId>
+ <artifactId>selenium-htmlunit-driver</artifactId>
+ <version>2.31.0</version>
+ <type>jar</type>
+ </dependency>
+ <dependency>
+ <groupId>org.seleniumhq.selenium</groupId>
+ <artifactId>selenium-firefox-driver</artifactId>
+ <version>2.31.0</version>
+ <type>jar</type>
+ </dependency>
+ <dependency>
+ <groupId>org.seleniumhq.selenium</groupId>
+ <artifactId>selenium-chrome-driver</artifactId>
+ <version>2.31.0</version>
+ <type>jar</type>
+ </dependency>
+ <dependency>
+ <groupId>org.seleniumhq.selenium</groupId>
+ <artifactId>selenium-ie-driver</artifactId>
+ <version>2.31.0</version>
+ <type>jar</type>
+ </dependency>
</dependencies>
<build>
@@ -155,28 +187,7 @@
<target>1.7</target>
<source>1.7</source>
</configuration>
- </plugin>
- <!--plugin>
- <groupId>${project.groupId}</groupId>
- <artifactId>${project.artifactId}</artifactId>
- <version>${project.version}</version>
- <executions>
- <execution>
- <id>auto</id>
- <phase>install</phase>
- <goals>
- <goal>check-site</goal>
- <goal>check-source-release</goal>
- </goals>
- <configuration>
- <configurationLines>
- <configurationLine>org.apache.maven.indexer;maven-indexer;https://dist.apache.org/repos/dist/release/maven/indexer/</configurationLine>
- <configurationLine>org.apache.maven.plugins;maven-ant-plugin;https://dist.apache.org/repos/dist/release/maven/plugins/</configurationLine>
- </configurationLines>
- </configuration>
- </execution>
- </executions>
- </plugin-->
+ </plugin>
</plugins>
</build>
@@ -205,6 +216,14 @@
</reportSets>
</plugin>
<plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>2.10</version>
+ <configuration><!-- help for netbeans -->
+ <configLocation>config/maven_checks.xml</configLocation>
+ </configuration>
+ </plugin>
+ <plugin>
<groupId>${project.groupId}</groupId>
<artifactId>${project.artifactId}</artifactId>
<version>${project.version}</version>
@@ -212,8 +231,9 @@
<reportSet>
<id>html</id>
<reports>
- <report>check-site</report>
- <report>check-source-release</report>
+ <!--<report>check-screen-site</report>-->
+ <report>check-site</report>
+ <!-- <report>check-source-release</report>-->
</reports>
</reportSet>
</reportSets>
Modified: maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/AbstractDistCheckMojo.java
URL: http://svn.apache.org/viewvc/maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/AbstractDistCheckMojo.java?rev=1489208&r1=1489207&r2=1489208&view=diff
==============================================================================
--- maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/AbstractDistCheckMojo.java (original)
+++ maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/AbstractDistCheckMojo.java Mon Jun 3 22:21:33 2013
@@ -23,13 +23,20 @@ import java.io.BufferedReader;
import java.io.File;
import java.io.IOException;
import java.io.InputStreamReader;
+import java.util.LinkedList;
import java.util.List;
+import org.apache.maven.artifact.factory.ArtifactFactory;
+import org.apache.maven.artifact.repository.ArtifactRepository;
+import org.apache.maven.artifact.repository.ArtifactRepositoryPolicy;
+import org.apache.maven.artifact.repository.MavenArtifactRepository;
+import org.apache.maven.artifact.repository.layout.DefaultRepositoryLayout;
import org.apache.maven.doxia.sink.Sink;
import org.apache.maven.doxia.siterenderer.Renderer;
import org.apache.maven.plugin.MojoExecutionException;
import org.apache.maven.plugins.annotations.Component;
import org.apache.maven.plugins.annotations.Parameter;
import org.apache.maven.project.MavenProject;
+import org.apache.maven.project.MavenProjectBuilder;
import org.apache.maven.reporting.AbstractMavenReport;
/**
@@ -55,6 +62,17 @@ public abstract class AbstractDistCheckM
@Component
protected MavenProject project;
+ @Parameter( property = "localRepository", required = true, readonly = true )
+ protected ArtifactRepository localRepository;
+
+ @Component
+ protected ArtifactFactory artifactFactory;
+
+ @Component
+ protected MavenProjectBuilder mavenProjectBuilder;
+
+ protected List<ArtifactRepository> artifactRepositories = new LinkedList<>();
+
abstract void checkArtifact( ConfigurationLineInfo request, String repoBase ) throws MojoExecutionException;
@Override
@@ -78,6 +96,8 @@ public abstract class AbstractDistCheckM
@Override
public void execute() throws MojoExecutionException
{
+ ArtifactRepository aa = new MavenArtifactRepository( "central", repoBaseUrl, new DefaultRepositoryLayout(), new ArtifactRepositoryPolicy( false, ArtifactRepositoryPolicy.UPDATE_POLICY_ALWAYS, ArtifactRepositoryPolicy.CHECKSUM_POLICY_WARN ), new ArtifactRepositoryPolicy( true, ArtifactRepositoryPolicy.UPDATE_POLICY_ALWAYS, ArtifactRepositoryPolicy.CHECKSUM_POLICY_WARN ) );
+ artifactRepositories.add( aa );
if ( configurationLines.isEmpty() )
{
try ( BufferedReader input = new BufferedReader( new InputStreamReader( Thread.currentThread().getContextClassLoader().getResource( MAVEN_DB ).openStream() ) ) )
Modified: maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/DistCheckSiteMojo.java
URL: http://svn.apache.org/viewvc/maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/DistCheckSiteMojo.java?rev=1489208&r1=1489207&r2=1489208&view=diff
==============================================================================
--- maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/DistCheckSiteMojo.java (original)
+++ maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/DistCheckSiteMojo.java Mon Jun 3 22:21:33 2013
@@ -51,7 +51,11 @@ import org.apache.maven.project.MavenPro
import org.apache.maven.reporting.MavenReportException;
import org.jsoup.HttpStatusException;
import org.jsoup.Jsoup;
+import org.jsoup.nodes.Comment;
import org.jsoup.nodes.Document;
+import org.jsoup.nodes.Element;
+import org.jsoup.nodes.Node;
+import org.jsoup.select.Elements;
/**
*
@@ -62,15 +66,6 @@ public class DistCheckSiteMojo extends A
{
private static final String MAVEN_SITE = "http://maven.apache.org";
- @Parameter( property = "localRepository", required = true, readonly = true )
- protected ArtifactRepository localRepository;
-
- @Component
- private ArtifactFactory artifactFactory;
-
- @Component
- private MavenProjectBuilder mavenProjectBuilder;
-
@Override
public String getOutputName()
{
@@ -95,6 +90,7 @@ public class DistCheckSiteMojo extends A
private String url;
private Map<HTMLChecker, Boolean> checkMap = new HashMap<>();
private int statusCode = 200;
+ private Document document;
public DistCheckSiteResult( ConfigurationLineInfo r, String version )
{
@@ -135,6 +131,45 @@ public class DistCheckSiteMojo extends A
return statusCode;
}
+ private void getSkins( Sink sink )
+ {
+ if ( statusCode != 200 )
+ {
+ sink.text( "None" );
+ }
+ else
+ {
+ String text = "";
+ Elements htmlTag = document.select( "html " );
+ for ( Element htmlTa : htmlTag )
+ {
+ Node n = htmlTa.previousSibling();
+ if ( n instanceof Comment )
+ {
+ text += (( Comment ) n).getData();
+ }
+ else
+ { text += "Nothing";
+ }
+ }
+
+ if ( isSkink( "Fluido" ) )
+ {
+ sink.text( "Fluido" );
+ }
+ else if ( isSkink( "Stylus" ) )
+ {
+ sink.text( "Stylus" );
+ }
+ else
+ {
+ sink.text( "Not determined" );
+ }
+ sink.monospaced();
+ sink.text( text );
+ sink.monospaced_();
+ }
+ }
private void getOverall( Sink sink )
{
@@ -159,12 +194,29 @@ public class DistCheckSiteMojo extends A
}
}
}
+
+ private boolean isSkink( String skinName )
+ {
+ boolean tmp = false;
+ for ( Map.Entry<HTMLChecker, Boolean> e : checkMap.entrySet() )
+ {
+ if ( e.getKey().getSkin().equals( skinName ) )
+ {
+ tmp = tmp || e.getValue();
+ }
+ }
+ return tmp;
+ }
+
+ private void setDocument( Document doc )
+ {
+ this.document = doc ;
+ }
}
// keep result
private List<DistCheckSiteResult> results = new LinkedList<>();
private final List<HTMLChecker> checker = HTMLCheckerFactory.getCheckers();
- private List<ArtifactRepository> artifactRepositories = new LinkedList<>();
-
+
@Override
protected void executeReport( Locale locale ) throws MavenReportException
{
@@ -190,7 +242,7 @@ public class DistCheckSiteMojo extends A
sink.body();
sink.section1();
sink.rawText( "Checked sites, also do some basic checking in index.html contents." );
- sink.rawText( "This is to help maintaining some choerence. How many site are skin fluido, stylus, where they have version (right left)" );
+ sink.rawText( "This is to help maintaining some coherence. How many site are skin fluido, stylus, where they have version (right left)" );
sink.rawText( "All sun icons in one column is kind of objective." );
sink.section1_();
sink.table();
@@ -205,10 +257,16 @@ public class DistCheckSiteMojo extends A
sink.rawText( "LATEST" );
sink.tableHeaderCell_();
sink.tableHeaderCell();
+ sink.rawText( "DATE" );
+ sink.tableHeaderCell_();
+ sink.tableHeaderCell();
sink.rawText( "URL" );
sink.tableHeaderCell_();
sink.tableHeaderCell();
- sink.rawText( "Contents check summary details on your left ==>" );
+ sink.rawText( "Skins and comments on top of html (helping for date but not allways)" );
+ sink.tableHeaderCell_();
+ sink.tableHeaderCell();
+ sink.rawText( "Precise and overkill contents check summary details on your left ==>" );
sink.tableHeaderCell_();
for ( HTMLChecker c : checker )
{
@@ -243,7 +301,11 @@ public class DistCheckSiteMojo extends A
sink.rawText( getSimplifiedUrl( csr.getUrl() ) );
sink.link_();
sink.tableCell_();
-
+
+ sink.tableHeaderCell();
+ csr.getSkins( sink );
+ sink.tableHeaderCell_();
+
sink.tableHeaderCell();
csr.getOverall( sink );
sink.tableHeaderCell_();
@@ -298,14 +360,14 @@ public class DistCheckSiteMojo extends A
result.setUrl( pluginProject.getUrl() );
Document doc = Jsoup.connect( pluginProject.getUrl() ).get();
-
+
message.append( "Site for " ).append( pluginProject.getArtifactId() ).append( " at " ).append( pluginProject.getUrl() ).append( " seek for" ).append( pluginProject.getVersion() ).append( " " );
for ( HTMLChecker c : checker )
{
result.getCheckMap().put( c, c.isOk( doc, version ) );
message.append( "[" ).append( c.getName() ).append( c.isOk( doc, version ) ).append( "]" );
}
-
+ result.setDocument( doc );
getLog().warn( message.toString() );
}
@@ -355,8 +417,7 @@ public class DistCheckSiteMojo extends A
public void execute() throws MojoExecutionException
{
//resolve only to what we set
- ArtifactRepository aa = new MavenArtifactRepository( "central", repoBaseUrl, new DefaultRepositoryLayout(), new ArtifactRepositoryPolicy( false, ArtifactRepositoryPolicy.UPDATE_POLICY_ALWAYS, ArtifactRepositoryPolicy.CHECKSUM_POLICY_WARN ), new ArtifactRepositoryPolicy( true, ArtifactRepositoryPolicy.UPDATE_POLICY_ALWAYS, ArtifactRepositoryPolicy.CHECKSUM_POLICY_WARN ) );
- artifactRepositories.add( aa );
+
super.execute();
}
Copied: maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/DistCheckSiteTakeScreenMojo.java (from r1489084, maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/DistCheckSiteMojo.java)
URL: http://svn.apache.org/viewvc/maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/DistCheckSiteTakeScreenMojo.java?p2=maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/DistCheckSiteTakeScreenMojo.java&p1=maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/DistCheckSiteMojo.java&r1=1489084&r2=1489208&rev=1489208&view=diff
==============================================================================
--- maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/DistCheckSiteMojo.java (original)
+++ maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/DistCheckSiteTakeScreenMojo.java Mon Jun 3 22:21:33 2013
@@ -20,6 +20,7 @@ package org.apache.maven.dist.tools;
*/
import java.io.BufferedReader;
+import java.io.File;
import java.io.IOException;
import java.io.InputStreamReader;
import java.net.MalformedURLException;
@@ -33,6 +34,7 @@ import java.util.Map;
import javax.xml.bind.JAXBContext;
import javax.xml.bind.JAXBException;
import javax.xml.bind.Unmarshaller;
+import org.apache.commons.io.FileUtils;
import org.apache.maven.artifact.Artifact;
import org.apache.maven.artifact.factory.ArtifactFactory;
import org.apache.maven.artifact.repository.ArtifactRepository;
@@ -52,24 +54,21 @@ import org.apache.maven.reporting.MavenR
import org.jsoup.HttpStatusException;
import org.jsoup.Jsoup;
import org.jsoup.nodes.Document;
+import org.openqa.selenium.OutputType;
+import org.openqa.selenium.TakesScreenshot;
+import org.openqa.selenium.WebDriver;
+import org.openqa.selenium.firefox.FirefoxDriver;
/**
*
* @author skygo
*/
-@Mojo( name = "check-site" )
-public class DistCheckSiteMojo extends AbstractDistCheckMojo
+@Mojo( name = "check-screen-site" )
+public class DistCheckSiteTakeScreenMojo extends AbstractDistCheckMojo
{
private static final String MAVEN_SITE = "http://maven.apache.org";
- @Parameter( property = "localRepository", required = true, readonly = true )
- protected ArtifactRepository localRepository;
-
- @Component
- private ArtifactFactory artifactFactory;
-
- @Component
- private MavenProjectBuilder mavenProjectBuilder;
+
@Override
public String getOutputName()
@@ -163,7 +162,7 @@ public class DistCheckSiteMojo extends A
// keep result
private List<DistCheckSiteResult> results = new LinkedList<>();
private final List<HTMLChecker> checker = HTMLCheckerFactory.getCheckers();
- private List<ArtifactRepository> artifactRepositories = new LinkedList<>();
+
@Override
protected void executeReport( Locale locale ) throws MavenReportException
@@ -190,7 +189,7 @@ public class DistCheckSiteMojo extends A
sink.body();
sink.section1();
sink.rawText( "Checked sites, also do some basic checking in index.html contents." );
- sink.rawText( "This is to help maintaining some choerence. How many site are skin fluido, stylus, where they have version (right left)" );
+ sink.rawText( "This is to help maintaining some coherence. How many site are skin fluido, stylus, where they have version (right left)" );
sink.rawText( "All sun icons in one column is kind of objective." );
sink.section1_();
sink.table();
@@ -297,8 +296,16 @@ public class DistCheckSiteMojo extends A
MavenProject pluginProject = mavenProjectBuilder.buildFromRepository( pluginArtifact, artifactRepositories, localRepository, false );
result.setUrl( pluginProject.getUrl() );
+ getLog().error( pluginProject.getUrl() );
+
+ WebDriver driver = new FirefoxDriver();
+
+ driver.get( pluginProject.getUrl() + "index.html" );
+ File scrFile = ( (TakesScreenshot) driver ).getScreenshotAs( OutputType.FILE );
+ FileUtils.copyFile( scrFile, new File( r.getGroupId() + r.getArtifactId() + ".png" ) );
+ driver.close();
Document doc = Jsoup.connect( pluginProject.getUrl() ).get();
-
+ getLog().error( pluginProject.getUrl() );
message.append( "Site for " ).append( pluginProject.getArtifactId() ).append( " at " ).append( pluginProject.getUrl() ).append( " seek for" ).append( pluginProject.getVersion() ).append( " " );
for ( HTMLChecker c : checker )
{
@@ -355,8 +362,7 @@ public class DistCheckSiteMojo extends A
public void execute() throws MojoExecutionException
{
//resolve only to what we set
- ArtifactRepository aa = new MavenArtifactRepository( "central", repoBaseUrl, new DefaultRepositoryLayout(), new ArtifactRepositoryPolicy( false, ArtifactRepositoryPolicy.UPDATE_POLICY_ALWAYS, ArtifactRepositoryPolicy.CHECKSUM_POLICY_WARN ), new ArtifactRepositoryPolicy( true, ArtifactRepositoryPolicy.UPDATE_POLICY_ALWAYS, ArtifactRepositoryPolicy.CHECKSUM_POLICY_WARN ) );
- artifactRepositories.add( aa );
+
super.execute();
}
Modified: maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/checkers/FluidoHTMLChecker.java
URL: http://svn.apache.org/viewvc/maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/checkers/FluidoHTMLChecker.java?rev=1489208&r1=1489207&r2=1489208&view=diff
==============================================================================
--- maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/checkers/FluidoHTMLChecker.java (original)
+++ maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/checkers/FluidoHTMLChecker.java Mon Jun 3 22:21:33 2013
@@ -32,6 +32,12 @@ public class FluidoHTMLChecker implement
}
@Override
+ public String getSkin()
+ {
+ return "Fluido";
+ }
+
+ @Override
public boolean isOk( Document doc, String version )
{
Element links = doc.select( "li#projectVersion" ).first();
Modified: maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/checkers/HTMLChecker.java
URL: http://svn.apache.org/viewvc/maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/checkers/HTMLChecker.java?rev=1489208&r1=1489207&r2=1489208&view=diff
==============================================================================
--- maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/checkers/HTMLChecker.java (original)
+++ maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/checkers/HTMLChecker.java Mon Jun 3 22:21:33 2013
@@ -36,6 +36,10 @@ public interface HTMLChecker
String getName();
/**
+ * skink related ?
+ */
+ String getSkin();
+ /**
* true if checker find pattern in document
*
* @param doc
Modified: maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/checkers/StylusLeftHTMLChecker.java
URL: http://svn.apache.org/viewvc/maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/checkers/StylusLeftHTMLChecker.java?rev=1489208&r1=1489207&r2=1489208&view=diff
==============================================================================
--- maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/checkers/StylusLeftHTMLChecker.java (original)
+++ maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/checkers/StylusLeftHTMLChecker.java Mon Jun 3 22:21:33 2013
@@ -32,6 +32,12 @@ public class StylusLeftHTMLChecker imple
}
@Override
+ public String getSkin()
+ {
+ return "Stylus";
+ }
+
+ @Override
public boolean isOk( Document doc, String version )
{
Element links = doc.select( "div.xleft" ).first();
Modified: maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/checkers/StylusRightHTMLChecker.java
URL: http://svn.apache.org/viewvc/maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/checkers/StylusRightHTMLChecker.java?rev=1489208&r1=1489207&r2=1489208&view=diff
==============================================================================
--- maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/checkers/StylusRightHTMLChecker.java (original)
+++ maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/main/java/org/apache/maven/dist/tools/checkers/StylusRightHTMLChecker.java Mon Jun 3 22:21:33 2013
@@ -32,6 +32,12 @@ public class StylusRightHTMLChecker impl
}
@Override
+ public String getSkin()
+ {
+ return "Stylus";
+ }
+
+ @Override
public boolean isOk( Document doc, String version )
{
Element links = doc.select( "div.xright" ).first();
Modified: maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/site/markdown/todo.md
URL: http://svn.apache.org/viewvc/maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/site/markdown/todo.md?rev=1489208&r1=1489207&r2=1489208&view=diff
==============================================================================
--- maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/site/markdown/todo.md (original)
+++ maven/sandbox/trunk/dist-tools/dist-tool-plugin/src/site/markdown/todo.md Mon Jun 3 22:21:33 2013
@@ -14,5 +14,9 @@ Todo
* Check if artifact versions are up to date in /plugins/, /shared/, /pom/ and so on
* remove "check if version present", since our inheritance ensures we don't have problems
* replace Skins columns with one unique column "Skin used", showing which skin is used (with version)
+ -- [RE] no garantee some site like http://maven.apache.org/plugins/maven-one-plugin/ have no style header
* add date of release (from artifact)
* add date of site
+
+# (for-fun)
+* take screenshot of site. ( os specific )