You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by yiming187 <gi...@git.apache.org> on 2016/09/30 13:29:25 UTC
[GitHub] zeppelin pull request #1477: [ZEPPELIN-1512] Support Kylin project name in i...
GitHub user yiming187 opened a pull request:
https://github.com/apache/zeppelin/pull/1477
[ZEPPELIN-1512] Support Kylin project name in interpreter runtime
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
### What type of PR is it?
Improvement
### Todos
DONE
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1512
### How should this be tested?
%kylin select ...
%kylin(new_project) select ....
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
No.
* Is there breaking changes for older versions?
No.
* Does this needs documentation?
Will do later.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yiming187/zeppelin ZEPPELIN-1512
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1477.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1477
----
commit 52c752f25ce18a7122c9e002ba9c17a5ee0fef4f
Author: Yiming Liu <li...@gmail.com>
Date: 2016-09-30T13:26:12Z
[ZEPPELIN-1512] Support Kylin project name in interpreter runtime
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1477: [ZEPPELIN-1512] Support Kylin project name in interpre...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1477
Thanks for the contribution. I'll start review this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1477: [ZEPPELIN-1512] Support Kylin project name in interpre...
Posted by yiming187 <gi...@git.apache.org>.
Github user yiming187 commented on the issue:
https://github.com/apache/zeppelin/pull/1477
Thanks @bzz , the rebase is done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1477: [ZEPPELIN-1512] Support Kylin project name in i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1477
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1477: [ZEPPELIN-1512] Support Kylin project name in interpre...
Posted by yiming187 <gi...@git.apache.org>.
Github user yiming187 commented on the issue:
https://github.com/apache/zeppelin/pull/1477
Thanks @bzz , there is no more commit from my side.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1477: [ZEPPELIN-1512] Support Kylin project name in interpre...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1477
@yiming187 thank you for improvement, looks good to me, \U0001f44d for having tests!
Could you please rebase it on the latest master, before merging it in?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1477: [ZEPPELIN-1512] Support Kylin project name in interpre...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1477
I've no preference about adding some properties in a paragraph but you need to update docs for that feature in details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1477: [ZEPPELIN-1512] Support Kylin project name in interpre...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1477
Thank you @yiming187 !
CI failures looks not relevant to the changes
```
Results :
Failed tests:
HeliumApplicationFactoryTest.testLoadRunUnloadApplication:160 expected:<Hello world 1> but was:<null>
Tests run: 122, Failures: 1, Errors: 0, Skipped: 0
```
and
```
Results :
Tests in error:
ParagraphActionsIT.testRemoveButton:155->AbstractZeppelinIT.clickAndWait:131 � ElementNotVisible
ParagraphActionsIT.testMoveUpAndDown:200->AbstractZeppelinIT.clickAndWait:131 � ElementNotVisible
ParagraphActionsIT.testCreateNewButton:85 � ElementNotVisible Element is not c...
Tests run: 18, Failures: 0, Errors: 3, Skipped: 0
```
Merging to master if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1477: [ZEPPELIN-1512] Support Kylin project name in interpre...
Posted by yiming187 <gi...@git.apache.org>.
Github user yiming187 commented on the issue:
https://github.com/apache/zeppelin/pull/1477
Hi @jongyoul , the doc is updated. Could you help review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---