You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/29 07:04:28 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1321: libc: Refine the inline handling
xiaoxiang781216 opened a new pull request #1321:
URL: https://github.com/apache/incubator-nuttx/pull/1321
## Summary
1.Remove CONFIG_HAVE_INLINE macro
2.Change the ANSI C function to normal function
3.Other simple non ANSI function to macro
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #1321: libc: Refine the inline handling
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #1321:
URL: https://github.com/apache/incubator-nuttx/pull/1321#discussion_r448158512
##########
File path: libs/libc/time/lib_timespec_get.c
##########
@@ -0,0 +1,34 @@
+/****************************************************************************
+ * libs/libc/time/lib_timespec_get.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <time.h>
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+int timespec_get(FAR struct timespec *t, int b)
+{
+ return b == TIME_UTC ? (clock_gettime(CLOCK_REALTIME, t), b) : 0;
Review comment:
better to make this usual style, rather than this one-line style.
##########
File path: include/stdlib.h
##########
@@ -147,15 +146,7 @@ int on_exit(CODE void (*func)(int, FAR void *), FAR void *arg);
/* _Exit() is a stdlib.h equivalent to the unistd.h _exit() function */
void _exit(int status); /* See unistd.h */
Review comment:
remove this copy of _exit prototype. it's only for the _Exit macro.
##########
File path: libs/libc/stdlib/lib_posix_memalign.c
##########
@@ -0,0 +1,35 @@
+/****************************************************************************
+ * libs/libc/stdlib/lib_posix_memalign.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <stdlib.h>
+#include <errno.h>
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+int posix_memalign(FAR void **mem, size_t align, size_t size)
+{
+ return (*mem = memalign(align, size)) ? OK : ENOMEM;
Review comment:
better to make this usual style, rather than this one-line style.
##########
File path: include/stdlib.h
##########
@@ -147,15 +146,7 @@ int on_exit(CODE void (*func)(int, FAR void *), FAR void *arg);
/* _Exit() is a stdlib.h equivalent to the unistd.h _exit() function */
void _exit(int status); /* See unistd.h */
-
-#ifdef CONFIG_HAVE_INLINE
-static inline void _Exit(int s)
-{
- _exit(s);
-}
-#else
-#define _Exit(s) _exit(s)
-#endif
+void _Exit(int status);
Review comment:
add noreturn_function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1321: libc: Refine the inline handling
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1321:
URL: https://github.com/apache/incubator-nuttx/pull/1321#discussion_r448336994
##########
File path: include/nuttx/compiler.h
##########
@@ -255,15 +255,6 @@
# undef CONFIG_PTR_IS_NOT_INT
#endif
-/* GCC supports inlined functions for C++ and for C version C99 and above */
-
-# if defined(__cplusplus) || (defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L)
Review comment:
Since inline doesn't work well in the old compiler, you can see each place which reference CONFIG_HAVE_INLINE have to provide two versions: one is inline function and another is macro which make the simple thing complex(@yamt and I have the same feeling). The better approach is:
1.Remove CONFIG_HAVE_INLINE
2.Implement the function as a normal(no inline) function as much as possible
3.For the simple and performance critical function:
a.Implement as the macro if it is an internal function
b.C standard function(like isspace) provide two versions:
1.Inline version if __cpluscplus__ define
2.Macro verson if __cpluscplus__ not define
Note: 3.b is required because the c++ library often write "using ::isspace" which is incompatible with macro.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1321: libc: Refine the inline handling
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1321:
URL: https://github.com/apache/incubator-nuttx/pull/1321#discussion_r448170872
##########
File path: include/stdlib.h
##########
@@ -147,15 +146,7 @@ int on_exit(CODE void (*func)(int, FAR void *), FAR void *arg);
/* _Exit() is a stdlib.h equivalent to the unistd.h _exit() function */
void _exit(int status); /* See unistd.h */
Review comment:
No, we can't, because all exit/_exit/_Exit specify in the standard:
https://linux.die.net/man/3/_exit
https://en.cppreference.com/w/c/program/exit
https://en.cppreference.com/w/c/program/_Exit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1321: libc: Refine the inline handling
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1321:
URL: https://github.com/apache/incubator-nuttx/pull/1321#discussion_r448336994
##########
File path: include/nuttx/compiler.h
##########
@@ -255,15 +255,6 @@
# undef CONFIG_PTR_IS_NOT_INT
#endif
-/* GCC supports inlined functions for C++ and for C version C99 and above */
-
-# if defined(__cplusplus) || (defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L)
Review comment:
Since inline doesn't work well in the old compiler, you can see each place which reference CONFIG_HAVE_INLINE have to provide two versions: one is inline function and another is macro which make the simple thing complex(@yamt and I have the same feeling). The better approach is:
1.Remove CONFIG_HAVE_INLINE
2.Implement the function as a normal(no inline) function as much as possible
3.For the simple and performance critical function:
a.Implement as the macro if it is an internal function
b.C standard function(like isspace) provide two versions:
1.Inline version if __cpluscplus__ define
2.Macro verson if __cpluscplus__ not define
Note: 3.b is required because the c++ library often write "using ::isspace" which is incompatible with macro.
The approach is better because:
1.Only need provide one version(either normal function or macro) in the most case
2.Have to provide two version(inline function and macro) for the C defined and performance critical function.
The case 2 happen seldomly and even in this case we can directly use ```__cpluscplus__ ``` because inline is the required feature for c++ compiler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1321: libc: Refine the inline handling
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1321:
URL: https://github.com/apache/incubator-nuttx/pull/1321#discussion_r448174046
##########
File path: include/stdlib.h
##########
@@ -147,15 +146,7 @@ int on_exit(CODE void (*func)(int, FAR void *), FAR void *arg);
/* _Exit() is a stdlib.h equivalent to the unistd.h _exit() function */
void _exit(int status); /* See unistd.h */
Review comment:
Ok, I misunderstand your comment, fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #1321: libc: Refine the inline handling
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #1321:
URL: https://github.com/apache/incubator-nuttx/pull/1321#discussion_r448178119
##########
File path: libs/libc/time/lib_timespec_get.c
##########
@@ -0,0 +1,42 @@
+/****************************************************************************
+ * libs/libc/time/lib_timespec_get.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <time.h>
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+int timespec_get(FAR struct timespec *t, int b)
+{
+ if (b == TIME_UTC)
+ {
+ clock_gettime(CLOCK_REALTIME, t);
Review comment:
it's better to check clock_gettime failure. it might not belong to this PR though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1321: libc: Refine the inline handling
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1321:
URL: https://github.com/apache/incubator-nuttx/pull/1321#discussion_r448336994
##########
File path: include/nuttx/compiler.h
##########
@@ -255,15 +255,6 @@
# undef CONFIG_PTR_IS_NOT_INT
#endif
-/* GCC supports inlined functions for C++ and for C version C99 and above */
-
-# if defined(__cplusplus) || (defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L)
Review comment:
Since inline doesn't work well in the old compiler, @davids5 here is the patch which add CONFIG_HAVE_INLINE:
https://github.com/apache/incubator-nuttx/commit/3b53cd1e578de1e6bddfae605452a77323e5a70b
You can see each place which reference CONFIG_HAVE_INLINE have to provide two versions: one is inline function and another is macro which make the simple thing complex(@yamt and I have the same feeling). The better approach is:
1.Remove CONFIG_HAVE_INLINE
2.Implement the function as a normal(no inline) function as much as possible
3.For the simple and performance critical function:
a.Implement as the macro if it is an internal function
b.C standard function(like isspace) provide two versions:
1.Inline version if ```__cpluscplus__``` define
2.Macro verson if ```__cpluscplus__``` not define
Note: 3.b is required because the c++ library often write "using ::isspace" which is incompatible with macro.
The approach is better because:
1.Only need provide one version(either normal function or macro) in the most case
2.Have to provide two version(inline function and macro) for the C defined and performance critical function.
The case 2 happen seldomly and even in this case we can directly use ```__cpluscplus__ ``` because inline is the required feature for c++ compiler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #1321: libc: Refine the inline handling
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #1321:
URL: https://github.com/apache/incubator-nuttx/pull/1321#discussion_r448307162
##########
File path: include/nuttx/compiler.h
##########
@@ -255,15 +255,6 @@
# undef CONFIG_PTR_IS_NOT_INT
#endif
-/* GCC supports inlined functions for C++ and for C version C99 and above */
-
-# if defined(__cplusplus) || (defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L)
Review comment:
This states that inline is not just a cpp @xiaoxiang781216 Did you ask @patacongo why this was abstracted the way it was?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #1321: libc: Refine the inline handling
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #1321:
URL: https://github.com/apache/incubator-nuttx/pull/1321#discussion_r448172499
##########
File path: include/stdlib.h
##########
@@ -147,15 +146,7 @@ int on_exit(CODE void (*func)(int, FAR void *), FAR void *arg);
/* _Exit() is a stdlib.h equivalent to the unistd.h _exit() function */
void _exit(int status); /* See unistd.h */
Review comment:
in the standards, _exit is in unistd.h, not stdlib.h.
we have an _exit prototype in unistd.h.
this prototype in stdlib.h is no longer necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1321: libc: Refine the inline handling
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1321:
URL: https://github.com/apache/incubator-nuttx/pull/1321#discussion_r448169311
##########
File path: libs/libc/stdlib/lib_posix_memalign.c
##########
@@ -0,0 +1,35 @@
+/****************************************************************************
+ * libs/libc/stdlib/lib_posix_memalign.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <stdlib.h>
+#include <errno.h>
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+int posix_memalign(FAR void **mem, size_t align, size_t size)
+{
+ return (*mem = memalign(align, size)) ? OK : ENOMEM;
Review comment:
Done.
##########
File path: libs/libc/time/lib_timespec_get.c
##########
@@ -0,0 +1,34 @@
+/****************************************************************************
+ * libs/libc/time/lib_timespec_get.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <time.h>
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+int timespec_get(FAR struct timespec *t, int b)
+{
+ return b == TIME_UTC ? (clock_gettime(CLOCK_REALTIME, t), b) : 0;
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1321: libc: Refine the inline handling
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1321:
URL: https://github.com/apache/incubator-nuttx/pull/1321#discussion_r448199508
##########
File path: libs/libc/time/lib_timespec_get.c
##########
@@ -0,0 +1,42 @@
+/****************************************************************************
+ * libs/libc/time/lib_timespec_get.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <time.h>
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+int timespec_get(FAR struct timespec *t, int b)
+{
+ if (b == TIME_UTC)
+ {
+ clock_gettime(CLOCK_REALTIME, t);
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #1321: libc: Refine the inline handling
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #1321:
URL: https://github.com/apache/incubator-nuttx/pull/1321#discussion_r448291057
##########
File path: include/nuttx/compiler.h
##########
@@ -255,15 +255,6 @@
# undef CONFIG_PTR_IS_NOT_INT
#endif
-/* GCC supports inlined functions for C++ and for C version C99 and above */
-
-# if defined(__cplusplus) || (defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L)
Review comment:
@patacongo does this change kill the retro computing support?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1321: libc: Refine the inline handling
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1321:
URL: https://github.com/apache/incubator-nuttx/pull/1321#issuecomment-650977066
For the more info why make this change, please see here: https://github.com/apache/incubator-nuttx/pull/1280
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt merged pull request #1321: libc: Refine the inline handling
Posted by GitBox <gi...@apache.org>.
yamt merged pull request #1321:
URL: https://github.com/apache/incubator-nuttx/pull/1321
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1321: libc: Refine the inline handling
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1321:
URL: https://github.com/apache/incubator-nuttx/pull/1321#discussion_r448172191
##########
File path: include/stdlib.h
##########
@@ -147,15 +146,7 @@ int on_exit(CODE void (*func)(int, FAR void *), FAR void *arg);
/* _Exit() is a stdlib.h equivalent to the unistd.h _exit() function */
void _exit(int status); /* See unistd.h */
-
-#ifdef CONFIG_HAVE_INLINE
-static inline void _Exit(int s)
-{
- _exit(s);
-}
-#else
-#define _Exit(s) _exit(s)
-#endif
+void _Exit(int status);
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1321: libc: Refine the inline handling
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1321:
URL: https://github.com/apache/incubator-nuttx/pull/1321#issuecomment-652767579
@yamt, If all concern get resolved, please help merge this patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1321: libc: Refine the inline handling
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1321:
URL: https://github.com/apache/incubator-nuttx/pull/1321#discussion_r448174046
##########
File path: include/stdlib.h
##########
@@ -147,15 +146,7 @@ int on_exit(CODE void (*func)(int, FAR void *), FAR void *arg);
/* _Exit() is a stdlib.h equivalent to the unistd.h _exit() function */
void _exit(int status); /* See unistd.h */
Review comment:
Ok, I misunderstand your comment, fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org