[jira] [Commented] (TWILL-131) Zookeepers nodes are not removed

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TWILL-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14959824#comment-14959824 ] 

ASF GitHub Bot commented on TWILL-131:
--------------------------------------

GitHub user chtyim opened a pull request:

    https://github.com/apache/incubator-twill/pull/70

    (TWILL-131) Remove ZK node when application finished.

    - Remove the application ZK node when the application terminates

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chtyim/incubator-twill feature/TWILL-131

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-twill/pull/70.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #70
    
----
commit 94a54da147cf74d7fd292369f6f28ea24b9d13b4
Author: Terence Yim <ch...@apache.org>
Date:   2015-10-14T20:39:32Z

    (TWILL-131) Remove ZK node when application finished.
    
    - Remove the application ZK node when the application terminates

----


> Zookeepers nodes are not removed
> --------------------------------
>
>                 Key: TWILL-131
>                 URL: https://issues.apache.org/jira/browse/TWILL-131
>             Project: Apache Twill
>          Issue Type: Bug
>          Components: discovery, zookeeper
>    Affects Versions: 0.5.0-incubating
>            Reporter: Colin B.
>            Assignee: Alvin Wang
>             Fix For: 0.7.0-incubating
>
>
> When a TwillRunnable is run with the YarnTwillRunnerService, a zookeeper node is created and never removed.
> For example run the example HelloWorld application:
> {code}
> java -cp $CP org.apache.twill.example.yarn.HelloWorld localhost:2181/hello
> {code}
> After the application had run to completion I looked at zookeeper and found:
> {code}
> > ./zkCli.sh ls /hello
> ...
> [HelloWorldRunnable]
> {code}
> However I expected:
> {code}
> > ./zkCli.sh ls /hello
> ...
> []
> {code}
> This becomes an issue when a service creates a large number of TwillApplications with unique names.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)