You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by be...@apache.org on 2025/02/28 21:24:21 UTC

(superset) branch master updated: fix(clickhouse): get_parameters_from_uri failing when secure is true (#32423)

This is an automated email from the ASF dual-hosted git repository.

beto pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 84b52b2323 fix(clickhouse): get_parameters_from_uri failing when secure is true (#32423)
84b52b2323 is described below

commit 84b52b23231de6661d6ecf9f80c70fcc14fa0142
Author: Le Xich Long <co...@users.noreply.github.com>
AuthorDate: Sat Mar 1 05:24:14 2025 +0800

    fix(clickhouse): get_parameters_from_uri failing when secure is true (#32423)
---
 superset/db_engine_specs/clickhouse.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/superset/db_engine_specs/clickhouse.py b/superset/db_engine_specs/clickhouse.py
index 0d40acbe67..8fb8e1d099 100644
--- a/superset/db_engine_specs/clickhouse.py
+++ b/superset/db_engine_specs/clickhouse.py
@@ -334,9 +334,9 @@ class ClickHouseConnectEngineSpec(BasicParametersMixin, ClickHouseEngineSpec):
         cls, uri: str, encrypted_extra: dict[str, Any] | None = None
     ) -> BasicParametersType:
         url = make_url_safe(uri)
-        query = url.query
+        query = dict(url.query)
         if "secure" in query:
-            encryption = url.query.get("secure") == "true"
+            encryption = query.get("secure") == "true"
             query.pop("secure")
         else:
             encryption = False
@@ -346,7 +346,7 @@ class ClickHouseConnectEngineSpec(BasicParametersMixin, ClickHouseEngineSpec):
             host=url.host,
             port=url.port,
             database="" if url.database == "__default__" else cast(str, url.database),
-            query=dict(query),
+            query=query,
             encryption=encryption,
         )