You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/17 12:44:46 UTC

[GitHub] [airflow] yuqian90 opened a new pull request #7276: [AIRFLOW-5391] Do not run skipped tasks when they are cleared

yuqian90 opened a new pull request #7276: [AIRFLOW-5391] Do not run skipped tasks when they are cleared
URL: https://github.com/apache/airflow/pull/7276
 
 
   This PR fixes the following issue:
   
   If a task is skipped by ``BranchPythonOperator``, ``BaseBranchOperator`` orr ``ShortCircuitOperator`` and the user then clears the skipped task, it'll execute. 
   
   After this PR:
   The ``NotPreviouslySkippedDep`` rule will first evaluate if a task has a direct ``SkipMixin`` parent that has decided to skip it. This is done by examining the XCom data stored by ``SkipMixin.skip()`` or ``SkipMixin.skip_all_except()``.
   
   The implementation is inspired by the author of [this blog](https://blog.diffractive.io/2018/08/07/replacement-shortcircuitoperator-for-airflow/).
   
   ---
   Issue link: [AIRFLOW-5391](https://issues.apache.org/jira/browse/AIRFLOW-5391)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services