You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/25 08:06:55 UTC
[GitHub] [apisix] wfnuser opened a new pull request #2846: feat: confirm only part of the etcd kvs
wfnuser opened a new pull request #2846:
URL: https://github.com/apache/apisix/pull/2846
### What this PR does / why we need it:
we only need to confirm part of result, returned list may change in the future.
#2800
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [x] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming merged pull request #2846: feat: confirm only part of the etcd kvs
Posted by GitBox <gi...@apache.org>.
moonming merged pull request #2846:
URL: https://github.com/apache/apisix/pull/2846
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #2846: feat: confirm only part of the etcd kvs
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2846:
URL: https://github.com/apache/apisix/pull/2846#issuecomment-734185876
Yes, you are right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] wfnuser commented on pull request #2846: feat: confirm only part of the etcd kvs
Posted by GitBox <gi...@apache.org>.
wfnuser commented on pull request #2846:
URL: https://github.com/apache/apisix/pull/2846#issuecomment-734907306
> Yes, you are right.
The pr is ready now.😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #2846: feat: confirm only part of the etcd kvs
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2846:
URL: https://github.com/apache/apisix/pull/2846#issuecomment-736613824
> Can we merge this pull request now? It seems that we need another approving review. @moonming
only 1 approval is not enough. we should wait for more time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] wfnuser commented on pull request #2846: feat: confirm only part of the etcd kvs
Posted by GitBox <gi...@apache.org>.
wfnuser commented on pull request #2846:
URL: https://github.com/apache/apisix/pull/2846#issuecomment-736611622
Can we merge this pull request now? It seems that we need another approving review. @moonming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] wfnuser commented on pull request #2846: feat: confirm only part of the etcd kvs
Posted by GitBox <gi...@apache.org>.
wfnuser commented on pull request #2846:
URL: https://github.com/apache/apisix/pull/2846#issuecomment-734123616
> you can make a try with this way, it is simpler way.
>
> ```shell
> make init
> cmd_res=`etcdctl --endpoints=127.0.0.1:2379 --user=root:apache-api6 get /apisix --prefix`
> etcdctl --endpoints=127.0.0.1:2379 --user=root:apache-api6 auth disable
> etcdctl --endpoints=127.0.0.1:2379 role delete root
> etcdctl --endpoints=127.0.0.1:2379 user delete root
>
> count=`echo $cmd_res | grep -c "/apisix/global_rules" || true`
> if [ $count -ne 1 ]; then
> echo "failed: failed to match '/apisix/global_rules'"
> exit 1
> fi
> ```
Thx. This is really the simpler way.
And I had some misunderstanding before. Actually we should check that there is some part of the ETCD keys must exists? If the particular key-value not exists in ETCD we should fail it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org