You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "FlyingZC (via GitHub)" <gi...@apache.org> on 2023/07/13 08:15:05 UTC

[GitHub] [shardingsphere] FlyingZC opened a new issue, #27154: Support parsing Oracle MERGE USING sql

FlyingZC opened a new issue, #27154:
URL: https://github.com/apache/shardingsphere/issues/27154

   # Background
   Hi community,
   This issue is for #26878.
   
   ShardingSphere parser engine helps users parse a SQL to get the AST (Abstract Syntax Tree) and visit this tree to get SQLStatement (Java Object). Currently, we are planning to enhance the support for Oracle SQL parsing in ShardingSphere.
   
   More details:
   https://shardingsphere.apache.org/document/current/en/reference/sharding/parse/
   
   # Task
   This issue is to support more oracle sql parse, as follows:
   ```sql
   MERGE USING Product_Changes S     -- Source/Delta table
   INTO Products D1                  -- Destination table 1
   ON (D1.PROD_ID = S.PROD_ID)       -- Search/Join condition
   WHEN MATCHED THEN UPDATE          -- update if join
   SET D1.PROD_STATUS = S.PROD_NEW_STATUS
   ```
   
   ```sql
   MODEL PARTITION BY (country) DIMENSION BY (product, time)
     MEASURES (sale sales, 0 mavg)
     RULES UPDATE
     (mavg[product IN ('Bounce', 'Y Box', 'Mouse Pad'), ANY] =
      AVG(sales)[CV(product), time BETWEEN CV(time) 
      AND CV(time) - 2])
   ```
   
   ```sql
   MODEL PARTITION BY (country) DIMENSION BY (year) MEASURES (sales)
     (sales[year=2001] = AVG(sales)[year BETWEEN 1990 AND 2000]
   ```
   
   ```sql
   NOAUDIT ALL ON DEFAULT;
   ```
   
   ```sql
   NOAUDIT ALL ON emp;
   ```
   
   # Process
   1. First confirm that this is a correct oracle sql syntax, if not please ignore;
   2. Compare SQL definitions in Oficial SQL Doc and ShardingSphere SQL Doc;
   3. If there is any difference in ShardingSphere SQL Doc, please correct them by referring to the Official SQL Doc;
   4. Run mvn install the current_file_module;
   5. Check whether there are any exceptions. If indeed, please fix them. (Especially xxxVisitor.class);
   6. Add new corresponding SQL case in SQL Cases and expected parsed result in Expected Statment XML;
   7. Run SQLParserParameterizedTest to make sure no exceptions.
   
   # Relevant Skills
   1. Master JAVA language
   2. Have a basic understanding of Antlr `g4` file
   3. Be familiar with Oracle SQLs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] github-actions[bot] commented on issue #27154: Support parsing Oracle MERGE USING sql

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27154:
URL: https://github.com/apache/shardingsphere/issues/27154#issuecomment-1676080368

   There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle MERGE USING sql [shardingsphere]

Posted by "PDGGK (via GitHub)" <gi...@apache.org>.
PDGGK commented on issue #27154:
URL: https://github.com/apache/shardingsphere/issues/27154#issuecomment-3726849986

     Hi @terrymanu @FlyingZC,
   
     I'd like to work on this issue.
   
     **Background:**
     - I'm a student preparing for GSoC 2026
     - I have experience with Java and ANTLR4
     - I've contributed to ShardingSphere's SQL parser module
   
     **Plan:**
     - Validate MERGE USING, MODEL clause, and NOAUDIT syntax against Oracle docs
     - Fix ANTLR grammar files in the Oracle dialect module
     - Implement corresponding visitor methods
     - Add test cases and run InternalOracleParserIT
   
     Could you please assign this issue to me? Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle MERGE USING sql [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu closed issue #27154: Support parsing Oracle MERGE USING sql
URL: https://github.com/apache/shardingsphere/issues/27154


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle MERGE USING sql [shardingsphere]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27154:
URL: https://github.com/apache/shardingsphere/issues/27154#issuecomment-1784212673

   There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle MERGE USING sql [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on issue #27154:
URL: https://github.com/apache/shardingsphere/issues/27154#issuecomment-5328977808

   Hi @FlyingZC, thanks for initiating this task. This issue has been fully addressed on the current master, so I am closing it as completed.
   
   - `MERGE INTO ... USING ... ON ... WHEN MATCHED THEN UPDATE` is supported by the `merge` rule in `DMLStatement.g4` with `visitMerge` producing `MergeStatement`, covered by Oracle cases in `merge.xml` such as `merge_update_and_insert_table`. Note the example SQL above writes `MERGE USING ... INTO ...`; the correct Oracle syntax order is `MERGE INTO ... USING ...`, which is what the parser supports.
   - The `MODEL` clause is supported by the `modelClause` rule in `DMLStatement.g4` (PARTITION BY / DIMENSION BY / MEASURES / RULES, with RULES optional), covered by Oracle cases such as `select_with_model_partition_dimension`.
   - `NOAUDIT` is supported by the `noAudit` rule in `DDLStatement.g4` since #29145, where `auditSchemaObjectClause` with `auditingOnClause` covers both `NOAUDIT ALL ON DEFAULT` and `NOAUDIT ALL ON emp`, covered by cases in `no-audit.xml`.
   
   Hi @PDGGK, thanks for your interest. Since the parsing support and test cases are already in place, there is no remaining work on this issue. You are welcome to pick up another `good first issue` from #26878 or the issue list.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org