You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by meggermo <gi...@git.apache.org> on 2015/12/28 16:10:01 UTC
[GitHub] httpclient pull request: Delete obsolete clone method
GitHub user meggermo opened a pull request:
https://github.com/apache/httpclient/pull/40
Delete obsolete clone method
In svn revision 980937 the Cloneable interface was removed from the class CacheEntity but the clone method was not. Assuming the removal of the Cloneable interface was intentional, the clone method should have been removed as well.
See https://fisheye6.atlassian.com/changelog/httpcomponents?cs=980937 for the entire change set.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/meggermo/httpclient clone-method-unnecessary
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/httpclient/pull/40.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #40
----
commit 1faa798a46f629824c4ba7b51b788c94b37a02e9
Author: Michiel Eggermont <mi...@gmail.com>
Date: 2015-12-28T11:26:34Z
Delete clone method
In svn revision 980937 the Cloneable interface was removed
from the CacheEntity but the clone method was not.
Assuming the removal of the Cloneable interface was
intentional, the clone method should have been removed
as well.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpclient pull request: Delete obsolete clone method
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the pull request:
https://github.com/apache/httpclient/pull/40#issuecomment-167711849
Committed to git master. Please verify and close. In Apache's Jira as [HTTPCLIENT-1709].
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpclient pull request: Delete obsolete clone method
Posted by meggermo <gi...@git.apache.org>.
Github user meggermo closed the pull request at:
https://github.com/apache/httpclient/pull/40
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org